jorgebucaran
Fisher install fails behind corporate proxy.
Because of the -q flag passed to curl it ignores ca certificates set inside ~/.curlrc. Fisher ignores the network error and proceeds to try to copy the contents of temp to source, leading to the error in the image. The plugins don't actually get installed
I could've sworn we dealt with this before, but hey, what do you think we should do now anyway? I'm open to adding an $flag perhaps?, but I need a clear understanding of the issue first. A PR with a minimal repro would be appreciated!
Is there a reason for ignoring the curlrc file? It could be simply removed and we would just need to properly error handle downloads
fisher install jorgebucaran/fisher
fisher install version 4.4.5
Fetching https://api.github.com/repos/jorgebucaran/fisher/tarball/HEAD
fisher: Invalid plugin name or host unavailable: "jorgebucaran/fisher"
same issue probably but my error is even less? I'm pretty sure it's the proxy though, I can see github just fine locally if I setup my proxy correctly.
The -q flag to ignore .curlrc seems to have been added, because people had all sorts of options laying in their .curlrcs, and those settings frequently messed up with Fisher (see 4c95fd94c62f38cd81418859fed31fc0786b3564).
If you have issues with custom certificates in your specific corporate environment, note that curl also supports environment variables for certs. See the following excerpts from the man page:
curl recognizes the environment variable named 'CURL_CA_BUNDLE' if it is
set and the TLS backend is not Schannel, and uses the given path as a path
to a CA cert bundle. This option overrides that variable.
(Windows) curl automatically looks for a CA certs file named 'curl-ca-bun‐
dle.crt', either in the same directory as curl.exe, or in the Current Work‐
ing Directory, or in any folder along your PATH.
...
SSL_CERT_FILE <path>
If set, it is used as the --cacert value. This environment variable is ig‐
nored if Schannel is used as the TLS backend.
SSL_CERT_DIR <dir>
If set, it is used as the --capath value. This environment variable is ig‐
nored if Schannel is used as the TLS backend.
