django-dajax icon indicating copy to clipboard operation
django-dajax copied to clipboard

Fix Dajax object visibility issue

Open Kami opened this issue 12 years ago • 2 comments

Problem Description

Currently Dajax object is not attach to the window object. This means it won't be visible to other code (ReferenceError: Dajax is not defined) if you use a minification process which wraps all of the minified files inside a closure (function(){}())).

Most of the minification libraries, including commonly used django-pipeline do that.

Proposed solution

In my proposed solution, I've wrap Dajax object into a closure and attach it to the window object. I've also did some cleanup and changed the code to consistently use $ everywhere instead of using jQuery in some and $ in other places.

Attaching an object to window object is a fairly common thing to do if the code, like this one, is not built as a jQuery plugin.

Kami avatar Sep 17 '13 14:09 Kami

@jorgebastida Would appreciate if you can have a look. Thanks!

Kami avatar Sep 18 '13 22:09 Kami

I've released my fork on pypi: https://pypi.python.org/pypi/django-dajax-ng

saz avatar Feb 06 '14 12:02 saz