Maintainerr icon indicating copy to clipboard operation
Maintainerr copied to clipboard

feat: Improve Tautulli settings UX

Open benscobie opened this issue 1 year ago • 1 comments

This PR improves Tautulli settings configuration by:

  • Merging Hostname, Port and Base URL inputs into one URL field. Users can simply copy and paste the URL from their browser.
    • I have added a migration to strip any slashes as the base URL input wasn't being stripped when constructing the URL
    • I have also ensured they're stripped for the older style settings
  • Implementing test before save like the *arr settings
  • Sharing client & server validation
  • Allowing saving of empty inputs (deleting the setting)
  • Returning more detailed error messages to the user. We forward any 400 error message we get back from Tautulli such as incorrect API key. We return the status codes in other situations, and lastly we return the exception message, which captures things like connection refused.

I have also fixed eslint not working in VSC, and have upgraded it and fixed the error in #1671

Fixes #1390

benscobie avatar Mar 07 '25 23:03 benscobie

Cannot save after a successful test

Edit: Not sure if this is relevant.

Edit 2: It wasn't relevant so I removed it.

image

ydkmlt84 avatar Apr 08 '25 15:04 ydkmlt84

It is not super clear what needs to be put into the URL field. I know what needs to be put there but maybe a sublabel under the URL label? The placeholder in the field helps a little bit, but not if you are using IP and port.

Copying the URL from the browser is nice except if you copy the whole thing, it has a subfolder at the end of it. http://192.168.1.91:8181/home is my URL, and this doesn't work in the URL field. I get a type error of undefined (reading 'message').

All functions work as intended. Can test without saving, clear settings, save changes once a successful test is performed. Just that one nitpick/suggestion.

ydkmlt84 avatar May 17 '25 01:05 ydkmlt84

It is not super clear what needs to be put into the URL field. I know what needs to be put there but maybe a sublabel under the URL label? The placeholder in the field helps a little bit, but not if you are using IP and port.

Copying the URL from the browser is nice except if you copy the whole thing, it has a subfolder at the end of it. http://192.168.1.91:8181/home is my URL, and this doesn't work in the URL field. I get a type error of undefined (reading 'message').

Ah yes fair point. I will add a few examples underneath the input and have a look at that error.

benscobie avatar May 17 '25 10:05 benscobie

:tada: This PR is included in version 2.15.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

jorenn92 avatar May 23 '25 14:05 jorenn92