Maintainerr icon indicating copy to clipboard operation
Maintainerr copied to clipboard

Tautulli connection fails with leading slash in base url

Open jgillman opened this issue 1 year ago • 11 comments

Describe the bug Tautulli connection fails when using a leading slash in base URL.

To Reproduce (self explanatory, see screenshots)

Expected behavior I would expect the connection to succeed with or without the leading slash in the base URL.

I'm not sure what the "standard" is but other similar services either automatically add/remove it or display an error. Overseerr, for example, says "URL base must have a leading slash" if it's not included to avoid confusion.

Screenshots

Fail with slash Fail with slash

Success without slash Success without slash

Nginx logs Nginx logs

Device:

  • OS: Slackware 15.0 x86_64 (docker container)
  • Version 2.2.1

Additional context Possibly related to https://github.com/jorenn92/Maintainerr/issues/1305 ?

My screenshots show that I'm connecting with docker networking hostnames but I've confirmed that the behavior is the same if I use a local IP address or external domain.

jgillman avatar Nov 20 '24 15:11 jgillman

You're right it could be documented better. I would prefer a leading slash as well. At the very least Tautulli is consistent with the Radarr & Sonarr base URL settings. For now we could just add some help text alongside the input as we've got other higher priority things to work on. A PR is welcome.

benscobie avatar Nov 20 '24 16:11 benscobie

Thanks for the quick reply, @benscobie! Agreed that just adding some help text would be sufficient here. I'll see if I can get a PR together.

jgillman avatar Nov 20 '24 16:11 jgillman

This is an easy documentation change for me. I will add it to the docs. Maintainerr UI will need a PR though. :)

ydkmlt84 avatar Nov 20 '24 16:11 ydkmlt84

Pushed the temp change to the develop branch.

Going forward, we would like to check for this on the server side and remove the slash if it is there. This will stay open until we implement that change.

ydkmlt84 avatar Nov 25 '24 17:11 ydkmlt84

Just to add on, I'm having issues getting Maintainerr to talk to my Tautulli that's using HTTPS with self signed certificates. Nothing in my docker logs, just "Connection failed!" in the UI and a request to /api/settings/test/tautulli with an NOK status.

mkaltner avatar Jan 23 '25 18:01 mkaltner

Just to add on, I'm having issues getting Maintainerr to talk to my Tautulli that's using HTTPS with self signed certificates. Nothing in my docker logs, just "Connection failed!" in the UI and a request to /api/settings/test/tautulli with an NOK status.

Makes sense as we haven't disabled certificate auth in anyway. Have you got any other apps that talk to services behind a self signed cert? I'm interested how they've implemented a solution.

We could let you specify paths of certs to include for authorisation. You'd need to add them as a mount. We could also provide an environment variable to disable SSL verification if people didn't want to bother with that and accept the security implications.

benscobie avatar Jan 23 '25 18:01 benscobie

I don't think I have anything else talks to Tautulli so I don't have other examples for that specifically. I generally don't use my reverse DNS when setting things up between eachother and Tautulli doesn't like to run in both HTTP and HTTPS very well. I've done things like install the certs on my phone and PC to help there. My certificates are available to all docker containers in the same location so either a docker setting or UI setting would be great, thanks!

mkaltner avatar Jan 23 '25 18:01 mkaltner

Also, is this related?

[maintainerr] | 23/01/2025 13:09:27 [INFO] [RuleExecutorService] Not all applications are reachable.. Skipped rule execution.

There is no delete setting for Tautulli (like there is Radarr/Sonarr) so does is Maintainerr erroring out because of that? I'm not using any Tautulli rules. All other applications are working correctly via the test button; Plex, Radarr, Sonarr.

Enabled debug logs, seems to be true. Would be nice to be able to disable/delete apps that aren't being used:

[maintainerr] | 23/01/2025 13:14:09 [DEBUG] [TautulliApi] GET request to https://192.168.1.5:8181/api/v2?apikey=9d6e0a48bc704ffc95bc11ba489f5bb0&cmd=get_tautulli_info failed: Error: unable to verify the first certificate [maintainerr] | 23/01/2025 13:14:09 [INFO] [RuleExecutorService] Not all applications are reachable.. Skipped rule execution.

mkaltner avatar Jan 23 '25 21:01 mkaltner

Also, is this related?

[maintainerr] | 23/01/2025 13:09:27 [INFO] [RuleExecutorService] Not all applications are reachable.. Skipped rule execution.

There is no delete setting for Tautulli (like there is Radarr/Sonarr) so does is Maintainerr erroring out because of that? I'm not using any Tautulli rules. All other applications are working correctly via the test button; Plex, Radarr, Sonarr.

Yes, all configured connections are tested regardless of whether they are included in rules or not. See #1416

benscobie avatar Jan 23 '25 21:01 benscobie

I submitted a pull request for this.

Image

Image

Image

mkaltner avatar Jan 25 '25 01:01 mkaltner

For now, I used DB Browser for SQL Lite to set the tautulli values in settings to NULL

Edit: which showed me my PR doesn't work correctly, closed it for now.

mkaltner avatar Jan 25 '25 03:01 mkaltner

:tada: This issue has been resolved in version 2.15.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

jorenn92 avatar May 23 '25 14:05 jorenn92