Jason Orendorff

Results 143 comments of Jason Orendorff

The problem is inside librdkafka. `rd_kafka_topic_partition_ensure_toppar` bumps the reference count of a `toppar` and stores it in a private field inside the partition topic list. This is the extra reference...

Right. It might be worth waiting to see if the librdkafka folks consider this a bug or not. Who knows, they might just fix it :) I filed an issue...

Well, that was quick. It's not a bug; it's [clearly documented here](https://github.com/edenhill/librdkafka/blob/master/INTRODUCTION.md#termination): > All objects except for the handle (C: `rd_kafka_t`, > C++: `Consumer,KafkaConsumer,Producer`), such as topic objects, messages, >...

As @edenhill put it: > all objects that have been used with a specific rd_kafka_t instance must be destroyed prior to destroying that rd_kafka_t instance. "have been used with": Hmm....

This issue is still referenced from the docs. @seanmonstar Is any part of this still open or did you fix all this 5+ years ago?

@michaelficarra This is very useful. Thanks. I have two follow-up questions: * In case 1, what does "local bindings" mean? * How does case 4 differ from case 3? Thinking...

I think this is an upstream bug. Filed https://github.com/rust-lang/rust/issues/64402 .

MakePrivateReference would look it up on the environment chain. This isn't much different from how it works in the current proposal. But instead of using ResolveBinding, there would be a...

One thing that I think is clearer if it's done this way is the parallel between the two-level scoping in `(function name1(a = EXPR1) { var name2; EXPR2; })` and...