MortyComposeKMM icon indicating copy to clipboard operation
MortyComposeKMM copied to clipboard

Episode does not render in SwiftUI

Open palmerhyde opened this issue 3 years ago • 6 comments

Hi John. I created a pull request for this but do not have permissions. If you grant me permissions I will try again.

in SwiftUI the episode number does not render. This is because episode.episode is in quotes. The fix is straightforward. In EpisodesListRowView.swift on line 13:

change Text("episode.episode") to Text(episode.episode)

palmerhyde avatar Nov 25 '22 23:11 palmerhyde

Hi, I don't think I should have to grant permission to open PR...where are you seeing that that's the case? I'll double check if any settings need to be updated for you repo

joreilly avatar Nov 25 '22 23:11 joreilly

Hmm, a few other folks have created PRs for this repo

joreilly avatar Nov 25 '22 23:11 joreilly

We're you able to create fork?

joreilly avatar Nov 26 '22 08:11 joreilly

I think it is a permissions issue on my side. I am investigating

palmerhyde avatar Nov 28 '22 16:11 palmerhyde

I am able to create a fork.

palmerhyde avatar Nov 28 '22 16:11 palmerhyde

Yeah, there is something wrong with the permissions on my end. I was able to create a fork, edit within the fork and then create a pull request from my fork into your repo.

palmerhyde avatar Nov 28 '22 17:11 palmerhyde