flex

flex copied to clipboard

bigfootmeat

Currently flex has some differences from browsers. Should this be solved? ## Known - flex-direction: column, by default - flex: , accepts single number

EduardoRFS

Just noticing `esy test` run two binary but the first doesn't exit zero so the second is not run.

Et7f3

`flex` was flexing on me with this error on OSX: ``` error: build failed with exit code: 1 build log: # esy-build-package: building: [email protected] # esy-build-package: pwd: /Users/bryphe/oni2/_esy/test/store/b/flex-1.2.2-b1a3d88a # esy-build-package:...

bryphe

This commit removes `HardCodedEncoding` and practically allows us to use different scalars than ints.

wokalski

https://github.com/jordwalke/flex/blob/fd0257ec12617f5d8c12752ce0ec690f15d249fb/src/lib/Layout.re#L75 Tradeoff: Any kind of specialized float comparison that uses an epsilon might be slower overall.

jordwalke

Does the `while` loop in step 8 ever run?

1

While reading the code, I noticed that `shouldContinue` is initialized to `false` and never gets set to `true`. I didn't do any verification beyond code inspection. https://github.com/jordwalke/flex/blob/fd0257ec12617f5d8c12752ce0ec690f15d249fb/src/lib/Layout.re#L1438-L1458

rigdern

Why does only setWidth mark the node dirty?

1

@yunxing Should the other setters also mark dirty? If so, I can add that - I was just curious if there was a reason.

jordwalke

We can ensure that polymorphic compare is not triggered by annotating these functions. It might even help fixed encoding performance slightly.

jordwalke