kubectl-plugins icon indicating copy to clipboard operation
kubectl-plugins copied to clipboard

Published 20 hours ago • verified publisher icon jordanwilson230

feat: Support for zsh

Open grzesuav opened this issue 5 years ago • 4 comments

Checklist

  1. Adresses Issue: https://github.com/jordanwilson230/kubectl-plugins/issues/9
  2. Quick summary of changes POC of new helper function definition
  3. Changes are GNU/BSD Compatable:yes
  4. Changes are applicable to the wider community: yes
  5. Request help with testing if needed: yes

grzesuav avatar Apr 10 '19 23:04 grzesuav

This is POC for now. I am not bash/zsh programmer so I am not aware of consequences. I tested this function locally on bash and zsh and it was working for me, but I have too limited knowledge to see bigger context

grzesuav avatar Apr 10 '19 23:04 grzesuav

please do not merge

grzesuav avatar Apr 10 '19 23:04 grzesuav

@grzesuav Hey! I branched off of you and opened another PR so you wouldn't have to play middleman and we go through two PR's to get it here. You can find the PR here: https://github.com/jordanwilson230/kubectl-plugins/pull/27

Of course left your fingerprints on the commits, lmk if you have any questions.

Jefferson-Faseler avatar Oct 09 '20 14:10 Jefferson-Faseler

no problem, good that you had time to carry this work :)

grzesuav avatar Oct 14 '20 20:10 grzesuav