fpm
fpm copied to clipboard
jordansissel
Handle clash between prefix and config-files
Previously the path under staging was ignoring the specified prefix when searching for config files, leading to file not found errors.
Addresses #730 and #584
We need this for more than just rpm. I just tried out the same fix on deb.rb and it seems to work there too. Mind expanding this PR a bit to cover other platforms?
Does really nobody care about this? @jordansissel ? You have a completely broken feature.
@ronkorving - I have? As in, I specifically own this broken feature? I'll own the fact that it is broken, but consider that I also have responsibility for so many things far greater than fpm: a full time job, a family, personal health, and more.
@ronkorving - Do you care? Do you care enough to test this patch and report whether it is functional, solves the problem, and doesn't introduce regressions? Could you help write tests to ensure the feature stays fixed long after this gets merged?
Or does your caring stop at some passive-aggressive rhetorical question that implies nobody else cares but you?
Bugs happen. I write lots of them. The way we solve this stuff in Open Source land is to work together. Accusatory broadcasts like "Does nobody care?" are not good teamwork. I suggest an alternative, "This also affects me. What can I do to help?"
Does nobody care? I care. I'm sure @michaeltchapman cares - as the provider of this patch. Thanks, btw, @michaeltchapman! :)
I'll try to make time for reviewing this, but anyone is welcome to contribute here to help get this merged by doing any, or all, of the following, as your energy and time permit:
- reporting that this bug affects you
- testing and reporting that it fixes the problem
- writing tests to ensure the fix stays fixed
- reviewing the code for any maintainability hazards
@ronkorving I was busy being quite irritated from your last comment that I didn't see your first one. Thanks for reporting that the fix works. As this patch doesn't solve your deb problems, I welcome contributions from yourself or anyone to improve it. Adding tests would also be lovely.
Yeah, I'm not gonna respond to that previous message written in rage. I see a PR that needs work, and notice that nobody cares despite my attempts to bring it in the spotlight. As reported, I've done what I can with the systems that I can test it on. It works (for me :)).
I'll be honest, my work life is very busy and I'm hardly a user of fpm at all (in other words: don't expect me to invest many hours into this for now (I would rather be honest about that)). I just used fpm once, ran into this problem, and would like to use fpm in the future. I figured you (plural) would care about this issue :)
@jordansissel apologies for lack of tests. I have no idea what I'm doing. I can close this if it's a blocking issue so that other contributors don't assume I'm going to fix it, when I don't know if I actually will.
@michaeltchapman no worries on lack of tests; someone will produce them if I don't :)
You're under no obligation to write such tests, btw!
Is this patch still needing to be merged? Sorry for the delays again.. Let me know - worst case, we can merge without tests and move forward. :)
How does it compare to #931? That seems more generalised and can be easily extended to Pacman coverage on top of just Deb/RPM.
