fpm icon indicating copy to clipboard operation
fpm copied to clipboard

DO NOT MERGE YET - .deb: Handle semver conversion when only one digit is present

Open torrancew opened this issue 10 years ago • 6 comments

Currently, if a gem has a semantic version requirement on a single digit number (aka "~> 3"), FPM winds up converting this into (in debian, at least) ">= 3" and "<< 0", which is obviously not satisfiable. The fix is fairly straightforward, but there is a test I've not yet figured out how to satisfy.

torrancew avatar Oct 25 '13 00:10 torrancew

@jkanywhere confirmed, this never did what the developer intended it to do. I'll revise this PR ASAP to do the right thing.

torrancew avatar Oct 31 '13 18:10 torrancew

Updated to handle parameters more up-to-spec, however, there's still one pesky test I've not resolved.

torrancew avatar Nov 05 '13 00:11 torrancew

@torrancew Care to rebase this one? It seems like an important fix.

thedrow avatar Oct 17 '14 13:10 thedrow

@thedrow Yes! I have let this slip for far too long, and will revisit ASAP.

torrancew avatar Apr 16 '15 23:04 torrancew

@torrancew anything we can do to help?

josephholsten avatar Jul 20 '17 23:07 josephholsten

@torrancew I've rebased this in #1380, would love your review!

josephholsten avatar Jul 21 '17 18:07 josephholsten