fpm
fpm copied to clipboard
dotenv upgrade caused problems
Related:
- https://github.com/jordansissel/fpm/issues/1918
- https://github.com/bkeepers/dotenv/issues/457
- https://github.com/jordansissel/pleaserun/issues/153
pleaserun
is probably not used much (if I had to guess). Further fpm
doesn't even use the part of pleaserun
that invokes dotenv
:
https://github.com/jordansissel/pleaserun/blob/fb79910a2dcdb26c463b02ce65d27bd34cbbdfdd/lib/pleaserun/platform/base.rb#L239
The feature in pleaserun that invokes dotenv
is when someone sets the --environment-file
flag when running the pleaserun
command-line tool. Looking at the fpm code using pleaserun, I'm pretty sure this feature is not used in fpm and it is safe to isolate away to prevent future fpm users having issues.
Proposal: In pleaserun
, either remove dotenv
dependency or isolate the require "dotenv/parser"
call to only load dotenv when it is needed instead of at startup.