fpm icon indicating copy to clipboard operation
fpm copied to clipboard

Test failure: Lintian check 'symlinks' was renamed '

Open jordansissel opened this issue 3 years ago • 1 comments

Problem: New test failures in the fpm deb test suite.

Context: A test that checks for #1840 by ensuring that fpm doesn't create a deb package that causes lintian to crash.

When preparing v1.14.2 for release, I noticed some new test failures that seem to be due to an upstream lintian change. As of about two years ago, lintian renamed the "symlink" check to be called "files/symbolic-links/broken"

References:

jordansissel avatar May 27 '22 04:05 jordansissel

Thinking about how to make this test pass across different lintian versions...

Maybe just try both? If both fail, then consider it a test failure. If one succeeds, we're ok.

That is, try:

  • lintian -C symlinks ...
  • lintian -C files/symbolic-links/broken ...

If one succeeds, the test passes. If both fail, the test should fail.

As an alternative, we could check the version number and invoke the correct test, but I'm not sure exactly when lintian made this change. It seems like Lintian 2.52.0, but there's so many tags in the lintian repo it's hard to tell, and I don't know how to interpret lintian version numbers vs what's included downstream in Debian and Ubuntu. Easier probably just to try both tests and accept the one that succeeds.

jordansissel avatar May 27 '22 04:05 jordansissel