fpm icon indicating copy to clipboard operation
fpm copied to clipboard

Published 20 hours ago • verified publisher icon jordansissel

freebsd pkg manifest needs "arch" over "abi" now

Open fetep opened this issue 8 years ago • 5 comments

Without an "arch" field, pkg just dumps core :(

"arch" is the new "abi" now, I guess: https://github.com/freebsd/pkg/commit/95b86714ed4cea7c75e92499a2307f9141d3687d

Format description from here: https://github.com/freebsd/pkg/blob/a3a2a2863d598702051a9e888d5194623c82ce51/libpkg/pkg_elf.c#L155-L159

fetep avatar Jun 22 '16 03:06 fetep

Any reason to even keep the --arch flag anymore? In RPM and DEB we use the architecture method to format the main flag FPM has. Looks like BSD was just using a separate flag because it was called ABI.

hatt avatar Jun 22 '16 08:06 hatt

The architecture method sounds fine; I'll poke at this soon and adjust.

fetep avatar Jun 23 '16 17:06 fetep

+1 on using the existing -a/--architecture flag. You can provide transforms for architecture values if needed. rpm and deb do these transforms and offer a default if not set, for example: https://github.com/jordansissel/fpm/blob/master/lib/fpm/package/rpm.rb#L222-L236

jordansissel avatar Jun 23 '16 17:06 jordansissel

@fetep Were you already able to take a look at this? I just spent a few hours trying to figuring out why pkgng was segfaulting on me so would be awesome if we could get it fixed. Please let me know if there's anything I can do to help.

Freeaqingme avatar Sep 26 '16 13:09 Freeaqingme

An associated PR for this has been merged and closed. If @Freeaqingme or @fetep would like to pull down the latest HEAD and confirm, that'd be great.

hatt avatar Oct 16 '16 22:10 hatt