Jordan Mack

Results 35 comments of Jordan Mack

@duanyytop It would be beneficial to add requirements to the steps for the Reproducible Build. Without them, many errors will be received since it requires specific versions of a number...

> I think the [CI configure](https://github.com/nervosnetwork/ckb-cheque-script/blob/main/.github/workflows/build_and_test.yml) is enough and @jordanmack how do you feel? Yes, that is adequate. Just add a line that links to this and describes what it...

@duanyytop I will be submitting a pull request with some additional suggestions for readability, but first I have some questions. ``` 1.b.i. It loops through all input cells using the...

@duanyytop I'm rewriting part of the description for clarity. I want to make sure I understand the functionality and intent correctly. The Cheque Lock can match against a `secp256k1-blake2b-sighash-all` signature,...

> The Cheque Lock only supports `secp256k1-blake2b-sighash-all` signature , so the sender and receiver can only use `secp256k1-blake2b-sighash-all` lock script to withdraw and claim the assets. When no witness is...

@duanyytop A few more questions in relation to Unlock Rule `2.b.ii`: I see that within `claim::validate()` it [locates the witness for the receiver input cell](https://github.com/duanyytop/ckb-cheque-script/blob/main/contracts/ckb-cheque-script/src/claim.rs#L24-L29), but then within `helpers::check_witness_args()` it...

> If the `WitnessArgs` is not empty for `secp256k1-blake2b-sighash-all`, the signature will be verified by the receiver lock script and Cheque Lock does not need to do repetitive things. Yes,...

I have created a new pull request to @duanyytop's branch with my suggested edits. Preview: https://github.com/jordanmack/duanyytop-rfcs/blob/add-cheque-lock/rfcs/0039-cheque/0039-cheque.md Pull Request: https://github.com/duanyytop/rfcs/pull/4 Commit Details: https://github.com/jordanmack/duanyytop-rfcs/commit/2b6b028ddf8a7df10288760a977e5aa9f1f6a0e4

> @jordanmack any questions? No more questions. Everything should be included in the PR.

The scheduling system I originally implemented in my program did as described, and slept for long periods until it was needed again. It worked fine unless the system went to...