Rename PollAdd's "flags" arg to "poll_mask" and make it type-safe

Open asayers opened this issue 9 months ago • 5 comments

The "io_uring_prep_poll_add" man page refers to this field as "poll_mask". I think it's worth following their naming, since io_uring_prep_poll_update() contains an unrelated field called "flags", in addition to "poll_mask". (This opcode is not yet supported by rustix-uring, but I imagine it might be in the future.)

Mar 29 '25 09:03 asayers

I wonder if op_flags_union's poll_32 variant should also be typed as EventFlags?

Mar 29 '25 23:03 asayers

Sounds reasonable. It appears there's one test failure to look into though.

Apr 01 '25 16:04 sunfishcode

Would you mind resolving the merge conflicts that have popped up in this PR?

Apr 23 '25 16:04 sunfishcode

I wonder if op_flags_union's poll_32 variant should also be typed as EventFlags?

Ah, I didn't notice that this type lives in rustix::io_uring, so this would be a seperate PR.

Apr 24 '25 00:04 asayers

I think this is ready to merge.

May 04 '25 14:05 asayers