homeage icon indicating copy to clipboard operation
homeage copied to clipboard

Allow name option in secretFile submodule

Open Gerschtli opened this issue 1 year ago • 2 comments

This follows common patterns used in nixpkgs and enables a bit more flexibility when using the homeage module.

Gerschtli avatar Sep 17 '22 14:09 Gerschtli

The nix functions I am using for generating the scripts utilize the name attribute. So this setting isn't actually doing anything currently as nothing references it. Would need to update those functions to instead utilize this new option.

jordanisaacs avatar Sep 18 '22 08:09 jordanisaacs

List of spots that need to be changed (github doesn't let me comment on unchanged lines ugh). Switch from using name to just the config:

  • decryptSecret (line 26, and all uses of it) - remove the use of name as a parameter
  • mkServices (line 337-340)
  • default for path (line 165)

jordanisaacs avatar Sep 18 '22 08:09 jordanisaacs

The longer I think about it, the less sense makes my change TBH. Not sure what you think. Because why would the key and the name option ever differ. I came up with this idea because of the way I use the module but in the end, I don't think it is worth the complexity. Feel free to reopen if you see it differently. :)

Gerschtli avatar Sep 21 '22 21:09 Gerschtli