nuclear-js-react-addons icon indicating copy to clipboard operation
nuclear-js-react-addons copied to clipboard

Comments on 0.3.0

Open dtothefp opened this issue 9 years ago • 3 comments

@jordangarcia I'm curious as to why you made some of the decisions on 0.3.0?

  • why is Provider only a container element, I was assuming you were doing it because Babel 6 doesn't support decorators yet but noticed connect is still a decorator (assuming your decision is related to this https://github.com/rackt/react-redux/issues/66?). Also, kind of a bummer you can no longer pass additional context as this was useful in our current apps, now would manually have to setup that context.
  • why does connect setup reactor.observe in componentWillMount. This potentially "solves" a lot of data binding issues I was having that I discussed with @Sinewyk because componentDidMount gets called from the inside out, so when binding initial state from actions in componentDidMount I would have to move this one level up above nuclearComponent to emit the Action. Seems easier this way but not very efficient if componentWillMount happens on both the client and server, seems pointless to setup reactor.observe on the server?
  • why is the anonymous function inside connect being called again in componentWillReceiveProps and reactor.observe being setup again here? Seems redundant? Previously this logic happened in componentDidMount
  • why is redux in peerDependencies and notnuclear-js` is there something going on I don't know about :-P?

dtothefp avatar Dec 23 '15 07:12 dtothefp

cc: @jordangarcia

gf3 avatar Feb 17 '16 23:02 gf3

I think this repo is maintained by @Sinewyk ?

singggum3b avatar Mar 23 '16 09:03 singggum3b

Kind of was. But I was not aware of the 0.3.0 so I can't answer this ^^.

Sinewyk avatar Mar 23 '16 10:03 Sinewyk