djantic icon indicating copy to clipboard operation
djantic copied to clipboard

Published 20 hours ago • verified publisher icon jordaneremieff

Allow abstract subclasses of ModelSchema

Open mikulas-mrva opened this issue 2 years ago • 4 comments

Adding the option to implement custom methods in abstract ModelSchema subclasses that cannot be instantiated and thus they don't have to undergo the strict checks that regular ModelSchemata need to fulfill.

Closes !62

mikulas-mrva avatar Nov 25 '22 18:11 mikulas-mrva

Thanks @mikulas-mrva. I'll need to fix some issue in GH workflow and try to review this on the weekend.

jordaneremieff avatar Nov 30 '22 12:11 jordaneremieff

@jordaneremieff Any way I can help with the workflow issues?

mikulas-mrva avatar Dec 23 '22 00:12 mikulas-mrva

@mikulas-mrva hey, sorry haven't had a chance to come back to this (that time of the year...). Sure if you want to open another PR that modifies the workflows file/passes then I can merge that and run it for this.

It looks like one of more of the Python versions specified for the tests is no longer available.

jordaneremieff avatar Dec 23 '22 01:12 jordaneremieff

@jordaneremieff I have changed 3.10.0 to 3.10 and added 3.11 now that it's out, but seems I need your approval to see if it helped.

mikulas-mrva avatar Dec 31 '22 17:12 mikulas-mrva