Jordan Tucker

Results 207 comments of Jordan Tucker

If you're not able to make those changes, I don't mind merging this and making them myself.

Also, I think I might rebase this against the v3 branch instead of main.

Yeah, that works. Maybe use `CHAR_0` instead though, just to make it more clear that these represent characters?

@lygstate Can you please explain what your issue is rather than just adding a link to an issue in another repo.

Would it work to add an `exports` field to `package.json` as described in [Dual CommonJS/ES module packages](https://nodejs.org/api/packages.html#packages_dual_commonjs_es_module_packages) and [Target environment independent packages](https://webpack.js.org/guides/package-exports/#target-environment-independent-packages)?

I'm trying to avoid breaking changes.

What about just assigning values to `exports` instead of reassigning `module.exports` like I did in #243? That should produce named exports along with the default export. I don't think that...

@ilanc > What's the correct way to import json5 from esm code? The current correct way is to `import JSON5 from 'json5/dist/index.mjs`, however this is not documented. In April, when...

@ilanc I wonder if copying `index.d.ts` into `node_modules/json5/dist` will resolve that error. If so, that would be an easy short term fix that I could publish. It might need to...

> I wonder if copying `index.d.ts` into `node_modules/json5/dist` will resolve that error. If so, that would be an easy short term fix that I could publish. It might need to...