email icon indicating copy to clipboard operation
email copied to clipboard

Named attachements

Open Sata51 opened this issue 5 years ago • 6 comments

Add the ability to attach a file with a custom file name Instead of using the default:

e := NewEmail()
e.AttachFile("test.txt")

you can provide a custom named file using this:

e := NewEmail()
e.AttachFileWithName("internalName.txt", "publicName.txt")

Sata51 avatar Mar 12 '19 11:03 Sata51

Hi @Sata51,

This LGTM but could you do me a favor and add a test that confirms the behavior is working as expected?

Thanks!

jordan-wright avatar Apr 07 '19 18:04 jordan-wright

I've done it :D

Sata51 avatar Apr 18 '19 15:04 Sata51

I was about to push a branch with this exact change. It's pretty essential since most files on servers have crazy names with timestamps lol

NoelHG avatar Jan 07 '20 07:01 NoelHG

@jordan-wright could you may take a look at this again?

Fank avatar Jun 02 '20 12:06 Fank

@Sata51 could you fix the conflicts?

Fank avatar Jun 02 '20 12:06 Fank

@Fank fixed

Sata51 avatar Jun 02 '20 13:06 Sata51