Nguyen Ngoc Son

Results 12 comments of Nguyen Ngoc Son

>I am confused. oracle_fdw already supports pushing down LIMIT and OFFSET and ORDER BY. I meant we pushdown Aggregation with the above clauses. As my investigation on postgres_fdw's code, we...

@hslightdb @laurenz It's under development now, please wait for my patch.

@laurenz As we discussed, I need to separate to small patches so you can review it. I'd like to share patches in the following order. You can review them one...

@laurenz Thanks for your feedback. I'd like to share all patches in the attachment. [aggregation_pushdown.zip](https://github.com/laurenz/oracle_fdw/files/11686107/aggregation_pushdown.zip) If you have any queries, please let me know.

I created patches based on the commit 7c65f589edeae1923e804b4315ddc1fa8894b1cf I developed on the following environment. * Centos 7 * OracleXE 21c * PostgreSQL 15.0

I'd like to explain more about the patches. 1) Patch1 * Refactor ORDER BY pushdown * Refactor deparse functions * Introduce a new way to create oratable for scanning table...

Sorry, I have not built and tested on other versions yet. I worked on PostgreSQL 15.0 because it is the latest stable version.

@laurenz >It does not apply to current master. Can yo fix that? Yes, I'll do that. >that confuses me, because a later patch introduces ORDER BY pushdown. The later patch...

@laurenz PostgreSQL 16beta1 was released. Do you want these patches working on 16beta1?

@laurenz Thanks for your information. I will use PostgreSQL 16beta2 Could you please confirm the separated patches at https://github.com/laurenz/oracle_fdw/issues/569#issuecomment-1628562120? If you do not agree, how small do you need patches?