Gyubong Lee
Gyubong Lee
I'm not sure about the PR but I think maybe not because this PR just update python built-in modules.
I'm waiting for this issue resolved before going further. https://github.com/RustPython/RustPython/issues/4157
I think this could be related to the below issue. https://github.com/chronotope/chrono/issues/815
Now, I'm waiting for the below PR to be merged and v0.5 to be released. https://github.com/chronotope/chrono/pull/827
Counter example: ## Expected result ``` >>> def f(): ... def g(): ... return 1 ... return 2 ... >>> f.__code__.co_consts (None, , 'f..g', 2) ``` ## Actual result ```...
> Counter example: This is resolved by [2426f11](https://github.com/RustPython/RustPython/pull/4174/commits/2426f11ebc76532b096ad951d0c49d9534b7ef83). Related test: https://github.com/python/cpython/blob/main/Lib/test/test_dis.py#L1402-L1411 https://github.com/python/cpython/blob/main/Lib/test/test_dis.py#L1447
I'm looking into this issue using `dis` module to the example code. RustPython's bytecodes of the example code are as follows. ``` 3 0 LoadGlobal (0, __name__) 1 StoreLocal (1,...
In the example code, `compile_name` with `v` is called twice when `v` is stored, and loaded. The problem here is when `v` is stored, it is not function scope, so...
So, I think maybe the problem here is the default argument `v`'s scope is evaluated as in the function's scope in the only lambda expression, which is not correct. ```...
* This PR adds `react`, `babel` to dependencies to rewrite in `ink`, and removes `inquirer` from dependencies. * Some features not having unit tests were tested by myself in macos....