[Feature Request]: Improved permissions for sheet

[jseaz73]

This allows the GM to distribute loot. I am leading a group of 5 - 11 yr old boys ...

I need all the help I can get!

[jopeek]

Haha I appreciate that. It’s a good suggestion. I’ll make a setting for this that will hide the loot/purchase buttons if desired.

On Jan 25, 2021, at 4:59 PM, jseaz73 [email protected] wrote:

 This allows the GM to distribute loot. I am leading a group of 5 - 11 yr old boys ...

I need all the help I can get!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[jseaz73]

You can not imagine the utter chaos that ensued when I introduced in my session and they just killed a pack of 8 kobolds and one high priest.

THANK YOU SO MUCH!

A couple of other things (I can make separate tickets if you would like)

• somehow they were able to MOVE the chest, it allows them to take control of the Chest PC?
• and LOOT All caused a lot of rage in the group ...
• When taking a dead NPC and converting it to use Loot Sheet it was also bringing over their abilities (like unarmed strike, their spells, claw attack (thank you twig blight)

[jseaz73]

Much LOVE!

On Wed, Mar 31, 2021 at 1:03 PM Jan Ole Peek @.***> wrote:

Closed #102 https://github.com/jopeek/fvtt-loot-sheet-npc-5e/issues/102.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jopeek/fvtt-loot-sheet-npc-5e/issues/102#event-4536061388, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD6DTFGSKY4Z65OO7ZVFOZLTGNIULANCNFSM4WSTZ6BA .

-- Regards,

Jason D. Siegrist Google Voice # 757 95-2-NAVY (6289) *sacram anchram solvere *

•    -* as flying to the last refuge.
  

[jopeek]

not actually done yet

[jseaz73]

LoL ... I will wait for it

On Wed, Mar 31, 2021 at 4:15 PM Jan Ole Peek @.***> wrote:

not actually done yet

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jopeek/fvtt-loot-sheet-npc-5e/issues/102#issuecomment-811432084, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD6DTFDMNPOH763YGO7EWJ3TGN7GRANCNFSM4WSTZ6BA .

-- Regards,

Jason D. Siegrist Google Voice # 757 95-2-NAVY (6289) *sacram anchram solvere *

•    -* as flying to the last refuge.
  

[Streyder]

@jopeek This seems like a part of a bigger decision, doesnt it? Currently you have the setup of 3 different rights:

• None
• Observer: allows users to grab things from the chest or merchant
• Owner: allows users to put stuff into a chest or add items to the merchant (which you actually never want I guess?)

By default foundry offers 4 different rights:

• None
• Limited
• Observer
• Owner

I think it would be a good idea to stick to this system in the loot sheet as well to make it consistent. Here would be my suggestion on how this would work out:

• None: normal foundry None: cannot see it, cannot access it
• Limited: can see everyhting in there but not interact with it (as requested in this issue)
• Observer: can loot chest or buy from merchant
• Owner: can put stuff in the chest. ??? Allow selling to a merchant once that feature is available ???

What do you think @jopeek? Would this be in your interessted to be implemented like this or do you have different ideas?

[jopeek]

@Streyder yeo I think that makes perfect sense to do it that way.

[jseaz73]

Yes that is what I was thinking as well

On Thu, Apr 1, 2021, 08:10 Streyder @.***> wrote:

@jopeek https://github.com/jopeek This seems like a part of a bigger decision, doesnt it? Currently you have the setup of 3 different rights:

• None
• Observer: allows users to grab things from the chest or merchant
• Owner: allows users to put stuff into a chest or add items to the merchant (which you actually never want I guess?)

By default foundry offers 4 different rights:

• None
• Limited
• Observer
• Owner

I thinki it would be a good idea to stick to this system in the loot sheet as well to make it consistent. Here would be my suggestion on how this would work out:

• None: normal foundry None: cannot see it, cannot access it
• Limited: can see everyhting in there but not interact with it (as requested in this issue)
• Observer: can loot chest or buy from merchant
• Owner: can put stuff in the chest. ??? Allow selling to a merchant once that feature is available ???

What do you think @jopeek https://github.com/jopeek? Would this be in your interessted to be implemented like this or do you have different ideas?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jopeek/fvtt-loot-sheet-npc-5e/issues/102#issuecomment-811863178, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD6DTFFS2X5C5YM7UUT6FADTGRPCFANCNFSM4WSTZ6BA .

[Streyder]

I am back in action. Hopefully I will have time within the next weeks to actually implement and test this. Sadly I am not yet familiar with the foundry access control system so I will need some time to get this right

[DanielBoettner]

@Streyder would you still be interested to take a look at this?

I could offer to give you a "tour of the code" so you understand the new refactored structure.

Also I would suggest to change it like this.

• None: normal foundry None: cannot see it, cannot access it
• Limited: can see everything in there but not interact with it (as requested in this issue)
• Observer: can loot (take or store) or trade (buy/sell) with a merchant
• Owner: Can update the sheet actor.

Someone also requested to allow buying/selling without a GM needed. A method that gets all users with sufficient permissions on the actor to update it, would be very useful with that. There are other things to keep in mind I think.