Joost Kremers

Results 208 comments of Joost Kremers

> > `ebib-fields-with-completion` > > I opened issue #251 for this, because it should probably be separate. Come to think of it, perhaps it should *not* be a separate issue....

I think it looks pretty good so far. I did find one bug (see my remark) and a few issues with doc strings (`flycheck` can list them for you), but...

> @joostkremers you might also want to have a look at the first paragraph of [this comment](https://github.com/minad/consult/issues/567#issuecomment-1116209256) regarding your selectrum issues? Hmm, OK, well, to be honest, I don't really...

> [author editing issues] > > Can you still edit the field though? As in, can you succesfully add more than one author with completing-read-multiple? Can't test right now, but...

> First, why does multiline editing store the new value separatley? It seems simpler to me to just return a string to `ebib-edit-field`, and have that function store it as...

> Secondly, does the current implementation of file editing work for you? Especially with regard to use of crm. If not, what doesn't work? Trying to edit an empty `file`...

For some strange reason, `ebib--edit-file-field` still had the old definition with no arguments, even though I had checked out your PR. Dunno what went wrong there, but starting from a...

> First. **tl;dr**: normal editing functions require unbraced init-contents, multiline functions require braced. Really? Did I do that? :anguished: :wink: [...] > How would you like to handle this? Wouldn't...

> I don't have time to test right now, but I think this is probably a selectrum issue, because [selectrum doesn't implement completion boundaries](https://github.com/minad/consult/issues/567#issuecomment-1116209256). Try executing `(completing-read-multiple "Prompt: " #'completion-file-name-table)`....

Yes, I can see how that could be confusing... The "this" refers to selecting multiple citations with Emacs' built-in completion mechanism. (TBH, I haven't tried out multiple selection with selectrum,...