Jonas L.

Results 432 comments of Jonas L.

I think we could cleanup the cache using https://github.com/savonet/liquidsoap/discussions/2601#discussioncomment-3567280

> Do we reuse files? As far as I know each schedule item is downloaded, even if they point to the same media file I think we will have some...

All files are cached, the problem is that we reuse the exact same file if it is scheduled again, and this would create a race when liquidsoap clean the file....

@milotype Thanks for the clarification. I still don't fully understand how to do it, I think I get your idea though. Could you open a Pull request with your proposal...

> I don't have a solution, so I don't understand why/how I should open a Pull request. I was just asking... And since I didn't understand what your requested, providing...

I am a bit confused on how we should generate the version. We should make it consistent and this PR isn't currently going in that direction. We generate the following...

Maybe we should simplify everything and include the latest tagged version, the current branch, and the current sha. For example changing the VERSION file to: For a tagged release: ```json...

I don't know why I'm trying to over engineer this. The idea might be good, but doesn't bring much. Back to a simple git describe.

For this pull request the LIBRETIME_VERSION is build with the GITHUB_REF_NAME and the GITHUB_SHA: `LIBRETIME_VERSION=2174/merge-81232017fec6056499debad03648bc6a2b7cee0c` but those versions are not tagged/published. On the LibreTime main branch we will have `LIBRETIME_VERSION=main-81232017fec6056499debad03648bc6a2b7cee0c`...

@JvL-exec Is this issue still relevant with the latest versions of LibreTime ?