syncnet_python icon indicating copy to clipboard operation
syncnet_python copied to clipboard

Is it okay that elements are removed from framefaces list while iterating over it?

Open hannarud opened this issue 2 years ago • 1 comments

In the file there is a for cycle over framefaces variable, and inside that cycle framefaces gets modified (faces that are already tracked are removed): https://github.com/joonson/syncnet_python/blob/6efbb1c305c23f47a62b09cf4215a8ac45e97d49/run_pipeline.py#L77 I'm not sure if this behavior is okay, because it may mean we loose some of the frames? At the same time, it all is getting executed in while loop, so maybe in the end the data is not lost. I might try to rewrite this, if the problem really exists. But maybe it's not. Do you think it is a problem? Should it be fixed?

hannarud avatar Sep 25 '22 10:09 hannarud

I'm confused too @hannarud

qwert1887 avatar Jan 28 '24 07:01 qwert1887