react-native-google-sign-in icon indicating copy to clipboard operation
react-native-google-sign-in copied to clipboard

Warning Issues for RNGoogleSignInEvents and RNGoogleSignIn

Open eggybot opened this issue 6 years ago • 5 comments

Module RNGoogleSignIn requires main queue setup since it overrides `constantsToExport` but doesn't implement `requiresMainQueueSetup`. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.
Module RNGoogleSignInEvents requires main queue setup since it overrides `init` but doesn't implement `requiresMainQueueSetup`. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

Hi I got this warning issue on RN iOS v0.53,0.54,0.55 , the login works fine but it shows some warning. Do we need to update the library to be able to comply with this yellow warnings?

thanks,

eggybot avatar Jun 07 '18 16:06 eggybot

+1 "react-native": "0.56.0"

sturmenta avatar Jul 12 '18 21:07 sturmenta

I has same issue

xuyendtk95 avatar Jul 13 '18 08:07 xuyendtk95

insert this code in RNGoogleSignin.m

+(BOOL)requiresMainQueueSetup { return YES; }

Hope it help you

TechDIY avatar Jul 19 '18 05:07 TechDIY

Same issue on RN 0.56, I'm not sure what the fix is to do a PR.

EDIT: Looks like someone has already submitted a PR in Dec, possible to get it merged? #64

adcuz avatar Aug 23 '18 09:08 adcuz

The original lib is now back in active development and the issue described here is no longer happening.

adcuz avatar Sep 03 '18 19:09 adcuz