Joon Ho Cho

Results 57 comments of Joon Ho Cho

I've recently created [BatchLoader](https://github.com/joonhocho/batchloader) written in TypeScript. Compared to DataLoader, it only does batching, but does it better. It shares identical apis (load, loadMany) with DataLoader. It handles duplicate keys...

@19majkel94 First, batchloader takes care of duplicate keys. For example, for the following code ```typescript loader.load(1), loader.load(2), loader.load(1), ``` with BatchLoader, your batch function will get [1, 2] as keys...

What about uploading?

Related https://github.com/jmurzy/react-router-native/issues/21.

I will definitely add examples tomorrow.

@jmurzy, Just created todo example with relay: https://github.com/joonhocho/react-native-router-relay-todo

@jmurzy, There are currently few bugs I can spot with the todo app. First, relay initially fetches data for `/complete` and `/any`. Not sure, why it fetches `/complete`. Second, when...

I've been looking into why it was rendering two lists after switching tabs, and I've found that it's because I am using [`Route` as a parent route](https://github.com/joonhocho/react-native-router-relay-todo/blob/master/src/routes.js#L11) instead of `StackRoute`...

More investigation on the bug. Not having the `applyAnimation` on `RouteView` was not the cause of the issue. The bug was caused by [NavigationAnimatedView.componentDidUpdate](https://github.com/facebook/react-native/blob/v0.28.0-rc.0/Libraries/NavigationExperimental/NavigationAnimatedView.js#L135). Removing the `if statement` fixed it.

https://github.com/facebook/react-native/issues/7422 may be related.