aws-es-proxy icon indicating copy to clipboard operation
aws-es-proxy copied to clipboard
verified publisher icon joona

Credential optimizations

Open martinzuern opened this issue 8 years ago • 2 comments

@joona Thanks for your latest release! However I needed to add some more changes to make this work on ECS.

I removed your custom defaultProviders chain, as it didn't include ECSCredentials. Instead, I'm setting the process.env.AWS_PROFILE variable, so AWS SDK still behaves like in previous versions.

AWS ECS Credentials require a refresh after some time, so I added a function that checks the credentials before every request and refreshes them if necessary.

martinzuern avatar May 31 '17 09:05 martinzuern

@joona is there anything I can do to help you to proceed here?

martinzuern avatar Jul 13 '17 10:07 martinzuern

Hi @martinzuern, thank you for pr and sorry for delay on gettin back to you.

I tested your branch, but unfortunately it's not fully compatible with non-AWS environment usecases (i.e. local development, with credentials profile, etc).

Since all outbound connections are handled on AWS SDK, it should handle the automatic refresh of credentials on demand when STS is used, at least this is my assumption.

joona avatar Nov 14 '17 21:11 joona