[6.0] correct URL for non-admin users with the email template: Content: New Article Submitted
Pull Request for Issue #46458 .
Summary of Changes
Change URL to site for non-admin users.
Testing Instructions
Open the Content: New Article Submitted email template and add the URL tag somewhere (it's not used by default).
Create a new user with a working email and assign them the Author/Publisher group, etc. (so they can create an article in the frontend but won't have access to the admin panel).
log in frontend like a superuser and submit an article
Actual result BEFORE applying this Pull Request
wrong url https://SITE/administrator/index.php?option=com_content&view=articles&filter[search]=id:17 for non superuser
Expected result AFTER applying this Pull Request
correct url for non superuser https://SITE/index.php?option=com_content&view=articles&id=nnn
Link to documentations
Please select:
-
[ ] Documentation link for docs.joomla.org:
-
[ ] No documentation changes for docs.joomla.org needed
-
[ ] Pull Request link for manual.joomla.org:
-
[ ] No documentation changes for manual.joomla.org needed
I have tested this item :white_check_mark: successfully on a57b5171812f3bd8e935a6e0f6c3e6dea706c5d5
It works, thanks. If the user isn't an admin, they get a working link to the article in the frontend.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46519.
even though the url is a site url (not admin) doesnt mean that the recipient of the email will be able to access the article. You are only checking to see if the recipient can access the admin. You are not checking if they can access the article
Check added
@Kostelano would you be able to retest now @alikon has added a new check please.
I have tested this item :white_check_mark: successfully on e4170af97b6ad507bfca861fca2f08b7b9ab27d9
Everything works as before
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46519.
I have tested this item ✅ successfully on e4170afEverything works as before
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46519.
Thank you, appreciate your time to retest
Sorry @alikon, I seem to not be receiving the wanted results ;(
After PR is applied, I still get this URL /_j6b2n/administrator/index.php?option=com_content&view=articles&filter[search]=id:23. ;(
Shows the front end user is logged in:
Shows the test user is of type Publisher (same results with Author, or Author + Publisher )
Shows the email result after creating email as Test User of type Publisher with Patch applied ;(
@exlemor if i understand correctly the user that submit the article is (Author, or Author + Publisher)
but the user for who you show the email (Emmanuel) have core.login privileges if that is correct, cause user (Emmanuel can see the submitted article from backend) then the link is correct that shows you the admin link
@exlemor if i understand correctly the user that submit the article is (Author, or Author + Publisher)
but the user for who you show the email (Emmanuel) have core.login privileges if that is correct, cause user (Emmanuel can see the submitted article from backend) then the link is correct that shows you the admin link
Hi @alikon, I should have added the other graphic sorry, for the Author (or Publisher) user, there is NO email that arrives to the [email protected] email account (I even checked server email logs) :/
@exlemor Check the profiles of these users. The option to receive system emails should be enabled for each one.
Regarding the link, everyone with access to the admin panel will receive a link to the admin panel. Others will receive a link to the article in the front-end.
Tested with JBT
- Created user 'editor' with 'Receive System emails' with group Author
- Added 'Create Article' home menu item
- Created new article via the frontend as the superuser
- Seen the link to the article in the backend with 404 for user author
- Applied PR with Patch Tester
- ✅ Seen working site URL, link is working for logged in user author or w/o login (as article is published)
- ⚠️ But if the article is created Unpublished by the superuser, user author gets an email with correct link, but resulting in 404
- This is as @brianteeman wrote
You are not checking if they can access the article
- This is as @brianteeman wrote
Is it intended that the user receives an email even if she cannot open the link? Then please adopt the test instructions and I will do an issue tracker test.
This also needs testing with workflows and when the created article is unpublished and the user doesn't have edit state permissions