joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[6.1] Remove default empty string param in addControlField()

Open Denitz opened this issue 2 months ago • 3 comments

Summary of Changes

New addControlField() method has $value as empty string by default, no sense to use empty string in method calls.

image

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

useless default param in code

Expected result AFTER applying this Pull Request

No changes.

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [x] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [x] No documentation changes for manual.joomla.org needed

Denitz avatar Oct 30 '25 08:10 Denitz

I have tested this item :white_check_mark: successfully on 1fbc46d3e0e7b021b9c5a3c0e9b00eb261387afd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46381.

RickR2H avatar Nov 14 '25 09:11 RickR2H

Such bigger refactoring should not be done in a patch version, so this PR would have to be made for 6.1-dev, I think.

@softforge @Bodge-IT Please check and decide.

richard67 avatar Nov 24 '25 10:11 richard67

Its a good catch @Denitz but not a bug as such so we will need to move to 6.1 where it can go in the alpha and get lots of testing.

softforge avatar Dec 04 '25 10:12 softforge