joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[6.1] remove featured article menu item

Open alikon opened this issue 2 months ago • 10 comments

Pull Request for Issue #46212.

Summary of Changes

removed featured article menu item

Testing Instructions

go to Content > Artciles

Actual result BEFORE applying this Pull Request

When you go to Content > Featured articles all (if any) featured articles are shown. If you then go to Content > Articles only featured articles are shown, since the filter for Featured articles is still active. If you clear the filteroptions no articles are shown.

Expected result AFTER applying this Pull Request

no more featured article menu item

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [ ] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [ ] No documentation changes for manual.joomla.org needed

alikon avatar Oct 04 '25 07:10 alikon

the system test failure is unrelated to the pr

image

alikon avatar Oct 04 '25 07:10 alikon

I am not convinced that removing the menu item is the correct solution. Also what happens to sites that have a custom admin menu for featured articles when they upgrade to this release

brianteeman avatar Oct 04 '25 08:10 brianteeman

what happens to sites that have a custom admin menu for featured articles when they upgrade to this release

the featured article menu item is removed as well

alikon avatar Oct 04 '25 09:10 alikon

This was discussed when the integration of featured into articles was made as PR. I would like to remove the menu item, but opinions were "keep it, then we must not explain".

chmst avatar Oct 04 '25 09:10 chmst

what happens to sites that have a custom admin menu for featured articles when they upgrade to this release

the featured article menu item is removed as well

From an existing custom menu? I doubt that

brianteeman avatar Oct 04 '25 11:10 brianteeman

I have tested this item :white_check_mark: successfully on 0fe1eb07d16c8634804c5db5d66ee0bb0b102fc3

The Featured menu item disappears. So it works if accepted.

During this test I edited a featured article to add a Read More break. On saving I got this error:

Unknown column 'is_current' in 'field list'

I reproduced it once but after I could not reproduce it at all, so I could not copy the stack trace. Curious!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46225.

So I did some other tests and then came back to move the Read More break in my featured article. On Save this error was triggered:

<h1>An error has occurred.</h1>
<blockquote class="blockquote">
<span class="badge bg-secondary">1054</span>
Unknown column 'is_current' in 'field list'
</blockquote>
<div>
<h2 id="caption">Call Stack</h2>

# | Function | Location
-- | -- | --
1 | () | JROOT/libraries/vendor/joomla/database/src/Mysqli/MysqliStatement.php:138
2 | mysqli->prepare() | JROOT/libraries/vendor/joomla/database/src/Mysqli/MysqliStatement.php:138
3 | Joomla\Database\Mysqli\MysqliStatement->__construct() | JROOT/libraries/vendor/joomla/database/src/Mysqli/MysqliDriver.php:972
4 | Joomla\Database\Mysqli\MysqliDriver->prepareStatement() | JROOT/libraries/vendor/joomla/database/src/DatabaseDriver.php:1753
5 | Joomla\Database\DatabaseDriver->setQuery() | JROOT/libraries/src/Versioning/VersionableModelTrait.php:466
6 | Joomla\Component\Content\Administrator\Model\ArticleModel->markVersionAsCurrent() | JROOT/libraries/src/Versioning/VersionableModelTrait.php:442
7 | Joomla\Component\Content\Administrator\Model\ArticleModel->storeHistory() | JROOT/libraries/src/Versioning/VersionableModelTrait.php:331
8 | Joomla\Component\Content\Administrator\Model\ArticleModel->saveHistory() | JROOT/libraries/src/MVC/Model/AdminModel.php:1470
9 | Joomla\CMS\MVC\Model\AdminModel->save() | JROOT/administrator/components/com_content/src/Model/ArticleModel.php:792
10 | Joomla\Component\Content\Administrator\Model\ArticleModel->save() | JROOT/libraries/src/MVC/Controller/FormController.php:689
11 | Joomla\CMS\MVC\Controller\FormController->save() | JROOT/libraries/src/MVC/Controller/BaseController.php:730
12 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143
13 | Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() | JROOT/libraries/src/Component/ComponentHelper.php:361
14 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT/libraries/src/Application/AdministratorApplication.php:150
15 | Joomla\CMS\Application\AdministratorApplication->dispatch() | JROOT/libraries/src/Application/AdministratorApplication.php:205
16 | Joomla\CMS\Application\AdministratorApplication->doExecute() | JROOT/libraries/src/Application/CMSApplication.php:320
17 | Joomla\CMS\Application\CMSApplication->execute() | JROOT/administrator/includes/app.php:58
18 | require_once() | JROOT/administrator/index.php:32

</div>

ceford avatar Nov 04 '25 16:11 ceford

I have tested this item :white_check_mark: successfully on 0fe1eb07d16c8634804c5db5d66ee0bb0b102fc3

Tested with JBT


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46225.

muhme avatar Nov 21 '25 16:11 muhme

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46225.

richard67 avatar Nov 22 '25 17:11 richard67

This is flagged as a feature so surely it cant be for 6.0

brianteeman avatar Nov 26 '25 08:11 brianteeman

Flagged as feature, moved to 6.1.

Bodge-IT avatar Dec 01 '25 19:12 Bodge-IT