joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard
verified publisher icon joomla

[6.1] Update core.es6.js

Open hans2103 opened this issue 3 months ago • 5 comments

Allow elements figure and figcaption to be used in popupContent of Joomla-Dialog

Summary of Changes

This PR will add figure and figcaption to the list of allowed elements in popupContent

Testing Instructions

  • create a dialog as described on https://manual.joomla.org/docs/general-concepts/javascript/js-library/joomla-dialog/ and use popupContent.
  • fill the popupContent with html including a figure containing an image and figcaption
  • render the page containing the dialog
  • open the dialog and inspect the code

Actual result BEFORE applying this Pull Request

  • notice the figure element is removed and the image is not shown, because of the removed figure element containing the image

Expected result AFTER applying this Pull Request

  • notice both figure and figcaption are present and the image is shown

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [ ] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [ ] No documentation changes for manual.joomla.org needed

hans2103 avatar Sep 13 '25 09:09 hans2103

Can you maybe also add other Content elements? https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements#content_sectioning

Fedik avatar Sep 13 '25 09:09 Fedik

@hans2103 since you're at it could you also add popovertarget and popovertargetaction to the button and popover in the div? ref: https://developer.mozilla.org/en-US/docs/Web/API/Popover_API

dgrammatiko avatar Sep 13 '25 16:09 dgrammatiko

@Fedik

Can you maybe also add other Content elements? https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements#content_sectioning

@dgrammatiko

@hans2103 since you're at it could you also add popovertarget and popovertargetaction to the button and popover in the div? ref: https://developer.mozilla.org/en-US/docs/Web/API/Popover_API

Both suggestions are legit but out of scope for me at this moment. Please test and approve this PR. Adding other elements should be done and tested in a separate issue.

hans2103 avatar Oct 04 '25 12:10 hans2103

This pull request has been automatically rebased to 5.4-dev.

HLeithner avatar Oct 15 '25 17:10 HLeithner

This pull request has been automatically rebased to 6.1-dev.

HLeithner avatar Oct 15 '25 18:10 HLeithner