joomla-cms
joomla-cms copied to clipboard
[6.0] Automated Update Quickicon language keys and icon
Summary of Changes
This PR changes a few language keys and replaces the icon to avoid portraying 'health' status for automated updates because we will later use 'health' and icons representing health for the Health Checker upcoming feature.
Testing Instructions
Install and check the status of the automated updates. The check should fail. The description of the quickicon is also impacted.
Actual result BEFORE applying this Pull Request
The user may be lead to think the whole system is at risk (there is no notion of automated updates).
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
[ ] Documentation link for docs.joomla.org:
-
[ ] No documentation changes for docs.joomla.org needed
-
[ ] Pull Request link for manual.joomla.org:
-
[ ] No documentation changes for manual.joomla.org needed
I have tested this item :white_check_mark: successfully on bd06a5e4a565fd447878c5eaf704bc74acd7259a
I have tested this successfully.
Merci @obuisard!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45614.
I have tested this item :white_check_mark: successfully on bd06a5e4a565fd447878c5eaf704bc74acd7259a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45614.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45614.
@obuisard As we introduce automated updates in 5.4 do we need a down-merge in 5.4 from this PR? (+ @richard67 – to be noticed)
I think this PR should be rebased to 5.4-dev. It does not make any sense at all to make these changes only in 6.0 so the UX for automated updates would differ between 5.4 and 6.0.
I think this PR should be rebased to 5.4-dev. It does not make any sense at all to make these changes only in 6.0 so the UX for automated updates would differ between 5.4 and 6.0.
I have no idea how to rebase from 6.0 to 5.4. Should I just recreate the PR for 5.4?
@obuisard Edit the title. Click the dropdown to select the branch to rebase to.
@obuisard Edit the title. Click the dropdown to select the branch to rebase to.
Thanks @QuyTon, I did, but like I tried locally, I end up with over 440 files to change...
@obuisard Re-create might be easier.
@obuisard P.S.: Ping me when there is a new PR so I can set the test results and RTC (if same as this one regarding code changes).
@obuisard P.S.: Ping me when there is a new PR so I can set the test results and RTC (if same as this one regarding code changes).
Thanks Richard @richard67. I created PR #45669, identical to this PR. I apologize for the mix-up.
@obuisard Closing this one here as the one for 5.4-dev will be merged up into 6.0-dev after it is merged into 5.4-dev.
Closing in favour of #45669 .