joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[6.0] Automated Update Quickicon language keys and icon

Open obuisard opened this issue 5 months ago • 3 comments

Summary of Changes

This PR changes a few language keys and replaces the icon to avoid portraying 'health' status for automated updates because we will later use 'health' and icons representing health for the Health Checker upcoming feature.

Testing Instructions

Install and check the status of the automated updates. The check should fail. The description of the quickicon is also impacted.

Actual result BEFORE applying this Pull Request

image

The user may be lead to think the whole system is at risk (there is no notion of automated updates).

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [ ] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [ ] No documentation changes for manual.joomla.org needed

obuisard avatar Jun 17 '25 03:06 obuisard

I have tested this item :white_check_mark: successfully on bd06a5e4a565fd447878c5eaf704bc74acd7259a

I have tested this successfully.

Merci @obuisard!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45614.

exlemor avatar Jun 17 '25 10:06 exlemor

I have tested this item :white_check_mark: successfully on bd06a5e4a565fd447878c5eaf704bc74acd7259a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45614.

tecpromotion avatar Jun 17 '25 19:06 tecpromotion

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45614.

tecpromotion avatar Jun 17 '25 19:06 tecpromotion

@obuisard As we introduce automated updates in 5.4 do we need a down-merge in 5.4 from this PR? (+ @richard67 – to be noticed)

muhme avatar Jun 27 '25 14:06 muhme

I think this PR should be rebased to 5.4-dev. It does not make any sense at all to make these changes only in 6.0 so the UX for automated updates would differ between 5.4 and 6.0.

richard67 avatar Jun 27 '25 14:06 richard67

I think this PR should be rebased to 5.4-dev. It does not make any sense at all to make these changes only in 6.0 so the UX for automated updates would differ between 5.4 and 6.0.

I have no idea how to rebase from 6.0 to 5.4. Should I just recreate the PR for 5.4?

obuisard avatar Jun 29 '25 21:06 obuisard

45614

@obuisard Edit the title. Click the dropdown to select the branch to rebase to.

QuyTon avatar Jun 30 '25 16:06 QuyTon

@obuisard Edit the title. Click the dropdown to select the branch to rebase to.

Thanks @QuyTon, I did, but like I tried locally, I end up with over 440 files to change...

obuisard avatar Jun 30 '25 16:06 obuisard

@obuisard Re-create might be easier.

richard67 avatar Jun 30 '25 16:06 richard67

@obuisard P.S.: Ping me when there is a new PR so I can set the test results and RTC (if same as this one regarding code changes).

richard67 avatar Jun 30 '25 16:06 richard67

@obuisard P.S.: Ping me when there is a new PR so I can set the test results and RTC (if same as this one regarding code changes).

Thanks Richard @richard67. I created PR #45669, identical to this PR. I apologize for the mix-up.

obuisard avatar Jun 30 '25 17:06 obuisard

@obuisard Closing this one here as the one for 5.4-dev will be merged up into 6.0-dev after it is merged into 5.4-dev.

richard67 avatar Jun 30 '25 18:06 richard67

Closing in favour of #45669 .

richard67 avatar Jun 30 '25 18:06 richard67