joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[6.0] Removing defs of JPATH_COMPONENT* from installation app

Open Hackwar opened this issue 8 months ago • 4 comments

Summary of Changes

The constants JPATH_COMPONENT, JPATH_COMPONENT_SITE and JPATH_COMPONENT_ADMINISTRATOR are deprecated, but Joomla itself is still using it in some places. Among them is the installation of the CMS, which defines these constants unnecessarily. This PR removes those definitions. Please be aware that this PR depends on #45249 to be merged.

Testing Instructions

Run through an installation of Joomla both in the browser and the CLI.

Actual result BEFORE applying this Pull Request

Everything works.

Expected result AFTER applying this Pull Request

Everything works, but we don't have the constants anymore.

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [ ] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [ ] No documentation changes for manual.joomla.org needed

Hackwar avatar Mar 28 '25 22:03 Hackwar

As I tested an installation successfully with #45249 this looks good to me

brianteeman avatar Mar 28 '25 22:03 brianteeman

I have tested this item :white_check_mark: successfully on d9da696204772829e3147f2958b43f2cfce81474


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.

brianteeman avatar Mar 28 '25 22:03 brianteeman

I have tested this item :white_check_mark: successfully on 4dceaaae04fb974ebb434be655251eeff17f3739

I have successfully tested this :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.

exlemor avatar May 10 '25 11:05 exlemor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.

QuyTon avatar May 10 '25 15:05 QuyTon

I have tested this item :white_check_mark: successfully on 751788c27704dd42f3fd7db91cacad1faaea8db6

Works same as 45249


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.

softforge avatar Jul 04 '25 15:07 softforge

~~Hmm, system tests are failing to start the installation. Response from server is "500: Internal Server Error".~~

Update 2025-07-22: Fixed with commit https://github.com/joomla/joomla-cms/pull/45250/commits/a5e946e029067333f524bdae1c2c9cfc6144ec35 .

richard67 avatar Jul 16 '25 23:07 richard67

I have tested this item :white_check_mark: successfully on cad0f1157fa7428200935f6555af6d75758f57c8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.

richard67 avatar Jul 22 '25 18:07 richard67

Back to pending as the PR has received a change. As I've just tested with success, it needs only one more test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.

richard67 avatar Jul 22 '25 18:07 richard67

@brianteeman @exlemor @softforge Could one of you three test this PR again? It has received changes so I have removed RTC, but I have tested it with success right now, so it needs only one more test. Thanks in advance.

richard67 avatar Jul 22 '25 18:07 richard67

I have tested this item :white_check_mark: successfully on cad0f1157fa7428200935f6555af6d75758f57c8

retested both web and cli installation


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.

brianteeman avatar Jul 22 '25 22:07 brianteeman

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45250.

richard67 avatar Jul 23 '25 07:07 richard67

@brianteeman Thanks for testing again.

@exlemor @softforge No further test needed, PR is RTC again.

richard67 avatar Jul 23 '25 07:07 richard67

Thank you @Hackwar for the work & @richard67 & @brianteeman & @softforge for the testing.

Bodge-IT avatar Aug 16 '25 14:08 Bodge-IT