[6.1] Re-ordering of tabs and fields in frontend
Pull Request for Issue #44118 . Replaces #44246 due to conflicts after rebasing
Summary of Changes
This PR re-arranges fields and tabs in frontend edit for articles. It moves all options which are in the right sidbar of articles to a new tab "options" It writes all fields which are in the publishing tab of the article into the publishing tab. This removes the language tab and the metadata tab.
Testing Instructions
It is a tricky test becaus there are countless combinations possible: multilingual or not, workflow integration or not, all combinations of settings for edit view ....
Compare the edit form for an article before and after the PR. Make sure that different user groups witrh different permissions have the same fields before and after the pr. Switch on and off the show_publishing_data in articles options. on: publishing tab exists, off: no publishing data. Check multilingual sites, if languages and associations are correct.
Actual result BEFORE applying this Pull Request
see #44118
Expected result AFTER applying this Pull Request
Tabs "options" and "publishing"
REMARK It would be correct to have a new param for switching on and off the publishing tab. Could be a follow-up PR.
Link to documentations
Please select:
-
[x] Documentation link for docs.joomla.org: (https://docs-next.joomla.org/help/articles/articles-edit/)
-
[ ] No documentation changes for docs.joomla.org needed
-
[ ] Pull Request link for manual.joomla.org:
-
[ ] No documentation changes for manual.joomla.org needed
I have tested this item :white_check_mark: successfully on 130af2aff5d041591ce70298eb6b76de4d2cbaee
Hi @chmst, I have tested this successfully.
Tried it on a non multi-lingual site, turning on/off options in the Articles Options, then installed Multi-Lingual Sample Data, and did the same... turned on/off workflows and many other settings in Articles and all good/correct from a perspective of your PR...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45081.
That said, (and this may be need to be done outside of this PR), I did find something odd but it has nothing to do with your PR because the behaviour appears with your PR is turned off/unpatched.
Workflow Turned OFF:
Workflow Turned ON:
@exlemor Same as in backend:
@fgsw - sure (thanks), but why is that? i.e. all of the other fields look the same, are selectable etc except these - even if it is because they shouldn't be selectable it's odd visually no?
I have tested this item :white_check_mark: successfully on 130af2aff5d041591ce70298eb6b76de4d2cbaee
Clean test, although metadata not as imaged but wrapped in context box. Not an aspect of the PR tho.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45081.
@Bodge-IT if your test does not match the expected result in the pull request it can not be a successful test - unless @chmst says that their images are wrong
@Bodge-IT if your test does not match the expected result in the pull request it can not be a successful test - unless @chmst says that their images are wrong
My test showed "Metadata" wrapper but this PR originally from 5.2 and does not affect nature of the PR.
what is the point in anyone testing anything if test results that are different to those expected are marked as successful
Hi @chmst , can you please update your result images to include the rendered < fieldset> and < legend> markup added by your code? or remove those tags to stay consistent with current images.
Setting to draft until the integration of workflow is checked.
Checked again.
If workflow is enabled, we have the same behaviour in backend as in frontend.
The fields for featured_up / _down are only visible if the article is featured.
I have tested this item :white_check_mark: successfully on 1257e8c12ce835cadea6e1f9dfebbbca1aea7c7d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45081.
Hi @chmst, in your screenshots you show:
Content / Images and Links / Options / Publishing,
On my test installation, I have:
Content / Publishing / Language
Any idea why the difference?
I have tested this item :white_check_mark: successfully on cb3c3e0048a3bee542a82470db320273c3fd394c
I like the re-ordering but I wonder if this can mess up some setups for editing in the frontend...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45081.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45081.
This pull request has been automatically rebased to 6.1-dev.
I have tested this item :white_check_mark: successfully on b0f4ef87a1ba4865b4371bbd301bb9953cca4dfe
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45081.