joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[cypress] Add db_port in Installation.cy.js

Open muhme opened this issue 1 year ago • 5 comments

Pull Request as a puzzle piece of Issue #43902

Summary of Changes

In the installation step of the system tests, support for the configuration of the database port is added.

Testing Instructions

The only isolated test that can be carried out for this change is that it does no harm.

You could see this PR is already used as hack in Joomla Branches Tester. There you can see it working in scripts/cypress.sh 44 local and running the Installation.cy.js step. Without the change (you have to comment-out the change in tests/System/integration/install/Installation.cy.js the Joomla Web Installer fails with:

Could not connect to the database. Connector returned error message: No such file or directory

Actual result BEFORE applying this Pull Request

The System Tests installation step cannot set the database port.

Expected result AFTER applying this Pull Request

The System Tests installation step can set the database port.

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [X] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [X] No documentation changes for manual.joomla.org needed

muhme avatar Aug 23 '24 16:08 muhme

Looks good to me.

rdeutz avatar Aug 29 '24 08:08 rdeutz

See also my PR for the database framework: https://github.com/joomla-framework/database/pull/310 . Would be good to know if the PR here still works with the changes from my framework PR.

richard67 avatar Sep 01 '24 09:09 richard67

from my testing result with https://github.com/joomla-framework/database/pull/310

just set db_host: 'localhost:5433', proprerly in cypress.config.js

alikon avatar Sep 01 '24 09:09 alikon

I have tested this item :white_check_mark: successfully on 9c2a993cd12a0f8b8acb7254e3b75c43c671d0e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43968.

alikon avatar Sep 28 '24 07:09 alikon

Can you rebase this one to 5.2?

laoneo avatar Oct 20 '24 14:10 laoneo

Rebased on 5.2-dev and checked System Tests on macOS with MariaDB passed

muhme avatar Oct 22 '24 05:10 muhme

Thanks!

laoneo avatar Oct 23 '24 03:10 laoneo