[4][com_scheduler] Manual Execution Rule blocks Lazy and Webcron

[alikon]

Pull Request for Issue #43767 .

Summary of Changes

Testing Instructions

see #43767

Actual result BEFORE applying this Pull Request

no task is executed if there is one Manual

Expected result AFTER applying this Pull Request

task is executed even if there is a Manual task

Link to documentations

Please select:

• [ ] Documentation link for docs.joomla.org:

• [ ] No documentation changes for docs.joomla.org needed

• [ ] Pull Request link for manual.joomla.org:

• [ ] No documentation changes for manual.joomla.org needed

[brbrbr]

I was wondering, wouldn't it be safer for future changes to clone the lockQuery

$idQuery= clone $lockQuery; // and move the $lockQuery->update part down.

This ensures that the conditions for idquery are always the same. And saves some code.

And I got a different issue while testing. If you trash a locked/running task, it blocks execution, since $lockCountQuery does not ignore trashed tasks.

[alikon]

And I got a different issue while testing. If you trash a locked/running task, it blocks execution, since $lockCountQuery does not ignore trashed tasks.

should be fixed

@brbrbr can you test ?

[brbrbr]

Hi,

I went through the different scenarios and all seems to work fine now.

Nice work, you reshuffled quite a bit code, don't like the 'clone' :)

A bit beyond this fix; Locking remains an issue. If a task crashes the whole cue get's locked. And i can't even force a run (or run an unlock task) since neither the CLI nor the WebCron pass the allowConcurrent option.

I have some thought about that: https://github.com/joomla/joomla-cms/discussions/43775

[softforge]

I have tested this item :white_check_mark: successfully on 1737666d450502aa236f460829d15aad3101b1ca

Works well, good catch

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43784.}

[mabdelaziz77]

I have tested this item :white_check_mark: successfully on 1737666d450502aa236f460829d15aad3101b1ca

It works for me. I have setup 1 manual task, 1 every minute and 1 every 2 minutes.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43784.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43784.}

[laoneo]

Thanks!