Update to joomla-cypress 1.1.0

[muhme]

Summary of Changes

The goal is to use NPM joomla-cypress version 1.1.0 also for 4.4-dev – so we can use one joomla-cypress version for all four active jooma-cms branches.

• joomla-cypress version is set to ^1.1.0
• The Cypress commands overwritten by System Tests for a faster session-based login have been removed as they are included in joomla-cypress.
• The check for PHP warnings has been reactivated. This led to errors in some places due to deprecated or warning messages. Since the end of regular bugfix support for 4.x is 15 October 2024 and these are not a problem in 5.1 upwards, they are simple avoided in system tests by workarounds.

⚠️ All other NPM packages are also updated with the npm update, see differences in package-lock.json.

Tested on Intel macOS 14.5 Sonoma with PHP 8.3.8, Ubuntu 24.04 LTS Noble Numbat with PHP 8.3.6 and Windows 11 with PHP 8.1.10.

Testing Instructions

• Install and run System Tests w/o errors
• Check version is 1.1.0 in node_modules/joomla-cypress/package.json
• Check that there were no effects from the updates in the NPM packages.

Actual result BEFORE applying this Pull Request

• System Tests using joomla-cypress version 0.0.16
• No PHP warning checks

Expected result AFTER applying this Pull Request

• System Tests using joomla-cypress version 1.1.0
• PHP warning checks are activated again (but simply avoided in 6 existing places with a workaround)

Link to documentations

Please select:

• [ ] Documentation link for docs.joomla.org:

• [X] No documentation changes for docs.joomla.org needed

• [ ] Pull Request link for manual.joomla.org:

• [X] No documentation changes for manual.joomla.org needed

Up-Merge

There is no need to up-merge this PR. However, the other active branches are currently using joomla-cypress version 1.0.3. To use joomla-cypress 1.1.0 also in the upper joomla-cms branches, it is necessary to run npm update.

[hans2103]

I have tested this item :white_check_mark: successfully on 9a66d94b03e82dad0b640fde60defd2fd3b6b921

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43722.}

[richard67]

@muhme Which command have you used to update the dependency? To me it seems this PR updates more dependencies than only joomla-cypress and it’s dependencies.

[muhme]

@muhme Which command have you used to update the dependency? To me it seems this PR updates more dependencies than only joomla-cypress and it’s dependencies.

@richard67 npm update to stay up-to-date with all dependencies. Should it changed to only update joomla-cypress and it’s dependencies?

[richard67]

Should it changed to only update joomla-cypress and it’s dependencies?

@muhme Yes. We don’t do dependency updates with patch versions. And to update all dependencies without even mentioning it in the description of this PR would not be good anyway. @laoneo can explain and decide.

[alikon]

the https://github.com/joomla/joomla-cms/pull/43726 should avoid the need for the hack in newsfeed and in the related_items module....

[muhme]

Set to DRAFT to:

• Only update joomla-cypress and it’s dependencies
• Remove joomla-cypress commands are overwritten in tests/System/README.md
• Wait for https://github.com/muhme/joomla-cms/pull/6
• Test again

[muhme]

And to update all dependencies without even mentioning it in the description of this PR would not be good anyway.

@richard67 Since the creation of this PR, the following statement has been included in the description:

⚠️ All other NPM packages are also updated with the npm update, see differences in package-lock.json.

The fact that all packages are updated is therefore explicitly named from my point of view and even provided with a visual eye-catcher. Also, the following instruction was added to the "Test Instructions" section since this PR was created:

• Check that there were no effects from the updates in the NPM packages.

Could it be that you haven't read the description, or am I the one who's in the wrong movie? 😃

[richard67]

@muhme Seems I need glasses 👓:-) You are right, description is ok, sorry for the noise :-)

[muhme]

Reverted to "Ready to merge", the description has been completely revised after all changes.

[laoneo]

Are the changes in the View classes really needed?

[muhme]

Are the changes in the View classes really needed?

In 4.4-dev with joomla-cypress 0.0.16 the PHP message and warningas checks were disabled. With joomla-cypress 1.1.0 they are enabled and the System tests had 6 failures. At first there were workaround 'hacks' in the system tests to get the test suite running without errors. @alikon solved all system test 'hacks' by backporting and investigating. @alikon: Can you explain more in detail?

[laoneo]

If these are bugs in the code, we should do them separate and then they need also two human tests.

[brianteeman]

Golden rule - solve one issue with one pull request

[laoneo]

As the other pr's are merged, can this one be changed to ready?

[muhme]

As the other pr's are merged, can this one be changed to ready?

No, it's intentionally set to 'Draft'. I would prefer to wait for the release of joomla-cypress 1.1.1 and then update this PR, set it on 'Ready to Merge' and create separate PR for all other branches, ok?

[muhme]

@laoneo Set to ready-for-review, as all preconditions have been fulfilled and the PR has been adjusted and pre-tested

@alikon Could you please test?

[laoneo]

Thanks!