joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.2] Integer custom field to be numerical input instead of a drop-down

Open sakiss opened this issue 1 year ago • 5 comments

Pull Request for Issue #42579

Summary of Changes

So far the Integer custom field is a drop-down list. Though it is crashing the browser when the list becomes too long. Moreover it is really hard to use, after a certain length.

With the PR the Integer custom field is an input of type number. Though, it still follows the min, max and step settings, that existed.

Testing Instructions

Try setting up a custom field of type "Integer" for an article. Within the article you will see an input, instead of a drop-down,

Actual result BEFORE applying this Pull Request

Drop-down list.

Expected result AFTER applying this Pull Request

Input of type number

Link to documentations

DKN

sakiss avatar Jun 24 '24 13:06 sakiss

Thanks for the PR. Before you continue. We should not change existing integer field. And instead of it, need to create a new Number custom field, which will use NumberField class.

Fedik avatar Jun 24 '24 15:06 Fedik

I have tested this item :white_check_mark: successfully on a8e9be46db8386b29c3bdc4e55f41b891d8ed3e3

This does what it says. But Fedik's suggestion below sounds logical to me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43697.

crommie avatar Aug 24 '24 08:08 crommie

I have tested this item :white_check_mark: successfully on a8e9be46db8386b29c3bdc4e55f41b891d8ed3e3

Works like described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43697.

pe7er avatar Aug 24 '24 08:08 pe7er

This breaks backwards compatibility and should be a new field

brianteeman avatar Aug 24 '24 08:08 brianteeman

Not setting RTC due to reason stated in previous comment. The "Updates requested" label is already set.

richard67 avatar Aug 24 '24 15:08 richard67

This pull request has been automatically rebased to 5.3-dev.

HLeithner avatar Sep 02 '24 08:09 HLeithner

@sakiss Can you please do the requested updates?

ghost avatar Jan 27 '25 08:01 ghost

I have tested this item :white_check_mark: successfully on a8e9be46db8386b29c3bdc4e55f41b891d8ed3e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43697.

komalm avatar Feb 22 '25 06:02 komalm

This pull request has been automatically rebased to 6.0-dev.

HLeithner avatar Mar 04 '25 17:03 HLeithner

Closed for reasons mentioned

sakiss avatar Mar 05 '25 14:03 sakiss