joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.2]Add option for show/hide title in readmore

Open rdeutz opened this issue 9 months ago • 12 comments

Pull Request for Issue #34609 .

Summary of Changes

Adding an option to the newsflash module to show, hide use global setting for the text at the read more button

Testing Instructions

  1. Read the issue and confirm the issue on Joomla 5.2 with sample data
  2. apply patch
  3. go to the "Latest Posts" module
  4. change the "Read More with Title" options in the module and check if the hide/show have the effect we want
  5. change the "Read More with Title" options in the module to "Use global article settings"
  6. go to content -> options and change under articles the Read More with Title and check if the hide/show have the effect we want

Actual result BEFORE applying this Pull Request

See issue

Expected result AFTER applying this Pull Request

You can control from the newflash module what text is at the read more button in the newsflash module

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [x] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [x] No documentation changes for manual.joomla.org needed

rdeutz avatar May 11 '24 09:05 rdeutz

I have not tested this item.

Not able to test, as instruction not clear. Where ist this module?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

KingLouis1 avatar Jul 15 '24 17:07 KingLouis1

I am bewildered. First you mention the «newsflash module». Later you ask «go to the "Latest Posts" module». I was unable to test thoroughly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

crimle avatar Jul 15 '24 17:07 crimle

Please test with the Articles - Newsflash module.

Quy avatar Jul 15 '24 18:07 Quy

I have tested this item :white_check_mark: successfully on 0a2af87b17da339c384b8f77e14c746f84c9a9b9

Should be 3. go to the "Articles - Newsflash" module NOT 3. go to the "Latest Posts" module then the testing instructions are comprehensible. My tests were successful.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

crimle avatar Jul 16 '24 08:07 crimle

I have tested this item :white_check_mark: successfully on 0a2af87b17da339c384b8f77e14c746f84c9a9b9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

viocassel avatar Jul 22 '24 13:07 viocassel

@rdeutz Could you check the changes suggested by @Quy ?

richard67 avatar Aug 03 '24 17:08 richard67

Hello, tested, it does work ✅ I have tested it in a Multi language environment (FR/ENG) All clear Best Phil

pcombet-adosis avatar Aug 22 '24 10:08 pcombet-adosis

Hello, tested, it does work ✅ I have tested it in a Multi language environment (FR/ENG) All clear Best Phil

@pcombet-adosis Please go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43457 and mark your test result by using the blue "Test this" button at the top left corner, selecting your test result and finally submit, so that your test is properly counted. Just a comment with a green check mark is not enough. Thanks in advance.

richard67 avatar Aug 22 '24 11:08 richard67

I have tested this item :white_check_mark: successfully on 0a2af87b17da339c384b8f77e14c746f84c9a9b9

I have tested it in a Multi language environment (FR/ENG) All clear

Best Philippe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

pcombet-adosis avatar Aug 22 '24 11:08 pcombet-adosis

I have tested this item :white_check_mark: successfully on 0a2af87b17da339c384b8f77e14c746f84c9a9b9

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

crommie avatar Aug 24 '24 08:08 crommie

I have tested this item :white_check_mark: successfully on 0a2af87b17da339c384b8f77e14c746f84c9a9b9

Did what it says on the tin


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

softforge avatar Aug 24 '24 08:08 softforge

As the last change after the successful human tests did just change the language string to the already existing global string, which is already used elsewhere in the same XML, which I've just checked by review, the previous human tests are still valid => RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43457.

richard67 avatar Aug 24 '24 09:08 richard67

This pull request has been automatically rebased to 5.3-dev.

HLeithner avatar Sep 02 '24 08:09 HLeithner