joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[cypress] nested set table #__menu

Open alikon opened this issue 1 year ago • 1 comments

Pull Request for Issue #43441 .

Summary of Changes

delete an item on nested set table

Testing Instructions

run npm run cypress:run -- --spec 'tests/System/integration/api/com_menus/SiteMenuItems.cy.js'

Actual result BEFORE applying this Pull Request

fail

Expected result AFTER applying this Pull Request

success

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [ ] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [ ] No documentation changes for manual.joomla.org needed

alikon avatar May 11 '24 09:05 alikon

I think we should really not use the "After" and "afterEach" event: https://docs.cypress.io/guides/references/best-practices#Using-after-Or-afterEach-Hooks

@laoneo

bembelimen avatar May 11 '24 09:05 bembelimen

still weird the drone failure

I would say "it works on my end" 🤕

alikon avatar Jun 03 '24 17:06 alikon

What can be that the chaining I pointed out here can cause the issues as the task function does run async. Try my suggestion, perhaps it brings an improvement.

laoneo avatar Jun 07 '24 12:06 laoneo

drone is happy now 👌

alikon avatar Jun 08 '24 07:06 alikon

I'v restarted drone

laoneo avatar Jun 12 '24 05:06 laoneo

Thanks!

laoneo avatar Jun 13 '24 13:06 laoneo