joomla-cms
joomla-cms copied to clipboard
[cypress] nested set table #__menu
Pull Request for Issue #43441 .
Summary of Changes
delete an item on nested set table
Testing Instructions
run npm run cypress:run -- --spec 'tests/System/integration/api/com_menus/SiteMenuItems.cy.js'
Actual result BEFORE applying this Pull Request
fail
Expected result AFTER applying this Pull Request
success
Link to documentations
Please select:
-
[ ] Documentation link for docs.joomla.org:
-
[ ] No documentation changes for docs.joomla.org needed
-
[ ] Pull Request link for manual.joomla.org:
-
[ ] No documentation changes for manual.joomla.org needed
I think we should really not use the "After" and "afterEach" event: https://docs.cypress.io/guides/references/best-practices#Using-after-Or-afterEach-Hooks
@laoneo
still weird the drone failure
I would say "it works on my end" 🤕
What can be that the chaining I pointed out here can cause the issues as the task function does run async. Try my suggestion, perhaps it brings an improvement.
drone is happy now 👌
I'v restarted drone
Thanks!