joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Update index.php - Installation template

Open sinahaghparast opened this issue 1 year ago • 7 comments

Pull Request for Issue # .

Summary of Changes

Streamlining a piece of code

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [ ] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [ ] No documentation changes for manual.joomla.org needed

sinahaghparast avatar May 02 '24 09:05 sinahaghparast

is it ok to declare a dependency before you use it.

brianteeman avatar May 02 '24 10:05 brianteeman

For better code readability. To comply with Fluent interface. To manage the consumption of server resources, even if it is small.

sinahaghparast avatar May 02 '24 11:05 sinahaghparast

That doesnt answer my question

brianteeman avatar May 02 '24 13:05 brianteeman

Maybe I didn't understand the question well. Please ask another way.

sinahaghparast avatar May 02 '24 17:05 sinahaghparast

With this change you are declaring that a script is dependent on other scripts that have not yet been declared. image

My question is if that is ok or not.

brianteeman avatar May 04 '24 06:05 brianteeman

I am so sorry. This was due to my carelessness.

Is that Ok now?

sinahaghparast avatar May 07 '24 19:05 sinahaghparast

I have tested this item :white_check_mark: successfully on 66bdb1f16192a697b37bc69b415b560791102a73

I see no errors after making the changes but there is an unnecessary blank line at 25 now the $this has been removed and the space above it no longer needed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43416.

softforge avatar Aug 24 '24 09:08 softforge

This pull request has been automatically rebased to 5.3-dev.

HLeithner avatar Sep 02 '24 08:09 HLeithner