joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.2] Deprecate HTMLHelper::script(), HTMLHelper::stylesheet(), extend lifetime for Document style/script methods

Open Fedik opened this issue 9 months ago • 1 comments

Pull Request for Issue # .

Summary of Changes

Deprecate HTMLHelper::script(), HTMLHelper::stylesheet(). Extend lifetime for Document style/script methods, because they cannot be removed before HTMLHelper::script(), HTMLHelper::stylesheet().

Add a new method HTMLHelper::mediaPath(), because we still need to lookup for overides. Kind of temporary solution, until someone will come up with improvements to our media override API.

Testing Instructions

Apply patch. Make sure all works as before.

Add media/templates/administrator/atum/css/user.css to atum template, and make sure it still works.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:
  • [ ] No documentation changes for docs.joomla.org needed
  • [ ] Pull Request link for manual.joomla.org: TBD
  • [ ] No documentation changes for manual.joomla.org needed

Fedik avatar Apr 28 '24 12:04 Fedik

I have tested this item :white_check_mark: successfully on 4dd7f9c637748ca26c2a3129abd0e3caf77ffa99


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43396.

degobbis avatar Aug 24 '24 17:08 degobbis

This pull request has been automatically rebased to 5.3-dev.

HLeithner avatar Sep 02 '24 08:09 HLeithner