joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.2] Update PHPUnit to 10

Open rdeutz opened this issue 1 year ago • 7 comments

Pull Request for Issue #42528 .

Summary of Changes

Update PHPUnit to the next major version because the current one we are using is outdated

Testing Instructions

Test/Merge after #43381

Unit test should work as before.

rdeutz avatar Apr 27 '24 15:04 rdeutz

@rdeutz It seems you are updating a lot of composer dependencies, see the lock file. Can it be that you have just run a composer update instead of a composer update phpunit/phpunit?

richard67 avatar Apr 27 '24 16:04 richard67

@richard67 try that and you will see why

brianteeman avatar Apr 27 '24 17:04 brianteeman

I have tested this item :white_check_mark: successfully on 4f5f61c7d7d6ac71b7ccb34b9ffa77c522b46629


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43393.

brianteeman avatar Apr 27 '24 17:04 brianteeman

I have tested this item ✅ successfully on 4f5f61c

@brianteeman You have noticed that both appveyor and drone are failing due to failing unit tests?

@rdeutz If that is expected because it needs the other PR, then your testing instructions should make that more clear.

richard67 avatar Apr 27 '24 17:04 richard67

@richard67 not sure what happened but when you replied to my comment you actually edited it. So it looks like I have said what you said. I have deleted it. and paste below

The composer lock updates are correct and if you try to do a composer update phpunit (as I said) then you will see why

Tests failing does not necessarily mean that the PR is wrong. It can also mean that the tests are wrong. We know that there are multiple tests that are either wrong or flakey.

I am well aware that these are failing unit tests which are failing. Thats what I was referring to.


As you can see now from Roberts ammended update the original update was correct. You just need to try it for yourself and you will see that you cannot just update phpunit without also updating a large batch of dependencies.

brianteeman avatar Apr 28 '24 15:04 brianteeman

not sure what happened but when you replied to my comment you actually edited it.

@brianteeman No idea what happened either, but it was not by purpose.

As you can see now from Roberts ammended update the original update was correct.

I know it needs to update a bunch of them, but in the first attempt there were definitely some included which are no dependencies of PHP unit. Now after the recent 2 commits it seems to be right.

richard67 avatar Apr 28 '24 15:04 richard67

@rdeutz If that is expected because it needs the other PR, then your testing instructions should make that more clear.

updated

one fail is expected when #43381 is not merged the other ones not

re-did the composer update

rdeutz avatar Apr 29 '24 07:04 rdeutz

closed in favor of #43865

rdeutz avatar Jul 30 '24 09:07 rdeutz

closed in favor of #43865

@rdeutz Forgotten to close?

richard67 avatar Jul 30 '24 11:07 richard67

yes

rdeutz avatar Jul 30 '24 11:07 rdeutz