joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Replace at feature in SessionManagerTest unit test

Open rdeutz opened this issue 1 year ago • 3 comments

Pull Request for Issue #42528 .

Summary of Changes

Remove the at() function because it is deprecated for phpunit10.

Site note: Can be discussed if the test has make sense in the past, here I only made it run.

Testing Instructions

run the unit test e.g. phpunit --testdox --filter SessionManagerTest

Actual result BEFORE applying this Pull Request

deprecated messages for the test

Expected result AFTER applying this Pull Request

no deprecated messages for the test

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [x] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [x] No documentation changes for manual.joomla.org needed

rdeutz avatar Apr 27 '24 11:04 rdeutz

This does not resolve the reported issue. "phpunit it out of date and unsupported"

brianteeman avatar Apr 27 '24 13:04 brianteeman

I want to do it in two steps, one to fix the test and when this is done update the phpunit version

rdeutz avatar Apr 27 '24 14:04 rdeutz

thats perfect and expected but you shoujldnt have closed the issue until both are done

brianteeman avatar Apr 27 '24 14:04 brianteeman

Thanks!

wilsonge avatar May 07 '24 22:05 wilsonge