joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Update to include MariaDB and remove SQL Server in README (.txt and .md)

Open robertsilen opened this issue 1 year ago • 5 comments
trafficstars

Considering the technical requirements (https://manual.joomla.org/docs/next/get-started/technical-requirements/) include MariaDB, I humbly suggest the README.txt should include MariaDB too. I removed "SQL Server" from list of databases, as mentioned in another discussion (https://github.com/joomla/joomla-cms/pull/43343). There is a separate PR for the .md version of the README.

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [ ] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [ ] No documentation changes for manual.joomla.org needed

robertsilen avatar Apr 25 '24 10:04 robertsilen

Please combine your PRs into one under the v4.4 branch as it will be upmerged to v5.1. Thanks.

Quy avatar Apr 25 '24 12:04 Quy

Please combine your PRs into one under the v4.4 branch as it will be upmerged to v5.1. Thanks.

I was told in PR for 4.4 to make a PR for 5.1 as this content is relevant for 5.1 and not 4.4. So I presume I should not go back on this?

Do you want me to merge this with the PR for README.md? Not sure how to do that.

robertsilen avatar Apr 25 '24 13:04 robertsilen

I was told in PR for 4.4 to make a PR for 5.1 as this content is relevant for 5.1 and not 4.4. So I presume I should not go back on this?

Commented in the other PR.

Do you want me to merge this with the PR for README.md? Not sure how to do that.

Switch to patch-4 branch. Apply the change from the other branch.

Quy avatar Apr 25 '24 13:04 Quy

I was told in PR for 4.4 to make a PR for 5.1 as this content is relevant for 5.1 and not 4.4. So I presume I should not go back on this?

Commented in the other PR.

Do you want me to merge this with the PR for README.md? Not sure how to do that.

Switch to patch-4 branch. Apply the change from the other branch.

This PR for 5.5 includes MariaDB and SQL Server modifications to README.txt and README.md now. For 4.4 version there is this PR.

robertsilen avatar Apr 26 '24 09:04 robertsilen

I have tested this item :white_check_mark: successfully on 1205699293a2407b7cccbada7864a684f6ea2f5a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43368.

Quy avatar May 07 '24 13:05 Quy

I have tested this item :white_check_mark: successfully on 1205699293a2407b7cccbada7864a684f6ea2f5a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43368.

viocassel avatar May 17 '24 13:05 viocassel

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43368.

Quy avatar May 17 '24 15:05 Quy

Thank you @robertsilen and for review @Quy @viocassel

LadySolveig avatar May 20 '24 12:05 LadySolveig