[5.2] Add missing Toggle inline help button to plugin modal / dialog

[Ruud68]

Pull Request for Issue https://github.com/joomla/joomla-cms/issues/43289#issuecomment-2063290211 .

Summary of Changes

plugin modal was missing Toggle inline help button

Testing Instructions

a. add a description to a field in the file ./plugins/system/redirect/redirect.xml e.g. to this field:

				<field
					name="collect_urls"
					type="radio"
					layout="joomla.form.field.radio.switcher"
					label="PLG_SYSTEM_REDIRECT_FIELD_COLLECT_URLS_LABEL"
					description="PLG_SYSTEM_REDIRECT_FIELD_COLLECT_URLS_LABEL"
					default="1"
					filter="integer"
					>
					<option value="0">JDISABLED</option>
					<option value="1">JENABLED</option>
				</field>

(line 6: description = has been added)

1. disable the system redirect plugin

2. goto com_redirect

3. in the alert telling you that the system redirect plugin is disabled, click on the link > the plugin will open in a modal

Actual result BEFORE applying this Pull Request

The modal had three buttons: Save, Save & Close and Close

Expected result AFTER applying this Pull Request

The modal has 4 buttons: Save, Save & Close, Close and Toggle inline help

Link to documentations

Please select:

• [ ] Documentation link for docs.joomla.org:

• [x] No documentation changes for docs.joomla.org needed

• [ ] Pull Request link for manual.joomla.org:

• [x] No documentation changes for manual.joomla.org needed

[dautrich]

I have tested this item :red_circle: unsuccessfully on 9ed546c8f5c13aaded187f8f411f868c2ebb32b0

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296.}

[brianteeman]

I have tested this item :red_circle: unsuccessfully on 9ed546c8f5c13aaded187f8f411f868c2ebb32b0

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296.}

[brianteeman]

Are you sure that is a good test instruction. That plugin doesnt show the toggle inline help button in a normal view either

[brianteeman]

I have tested this item :white_check_mark: successfully on 9ed546c8f5c13aaded187f8f411f868c2ebb32b0

after testing with a plugin that does have inline help I am changing my test result to successfull.

Please provide better testing instructions!!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296.}

[dautrich]

@brianteeman How did you test? Which plugin?

[brianteeman]

i edited the code so that I could test the sef plugin

[Ruud68]

Sorry everybody, instructions updated. Toggle inline Help button is hidden when there are no descriptions in the XML file. I have added a step to add a description to the redirect plugin. I also added visuals for what and where to click / what it will show.

Hope this makes it clear. Sorry for the confusion!

[Quy]

I have tested this item :white_check_mark: successfully on 9ed546c8f5c13aaded187f8f411f868c2ebb32b0

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296.}

[Ruud68]

Thanks for testing everybody! Appreciate you taking the time for it.

[LadySolveig]

Thank you for this great idea! As it is not yet available in other modals either, such as article new/edit or contact new/edit, I see it as a new feature. Since we only deal with bug fixes in 5.1, I will pass it on to the 5.2 team @pe7er @woluweb Could you imagine adding it to the other components as well @Ruud68 ? That would be wonderful!

[brianteeman]

Could you imagine adding it to the other components as well @Ruud68 ? That would be wonderful!

What other components?

[LadySolveig]

We have also dialogs for adding and editing contacts, articles and it would be nice if we could have it here also.

Not sure if I am missing something, where this could also be useful.

[brianteeman]

Sorry I must have confused this PR with another one as I was sure I had seen changed across all modals

[pe7er]

Thanks @Ruud68 ! It's a nice improvement! Actually, we would like to have this improvement in all Modal views, so we've created a new issue for that: https://github.com/joomla/joomla-cms/issues/43501 Could you please help out with that?