[4.4] Fixing non-SEF URL in feed output

[Hackwar]

Pull Request for Issue #39775.

Summary of Changes

When Joomla is installed in a subdirectory and URLs are set to be completely non-SEF, the URLs in a feed output are wrong. Specifically, the path to the root of Joomla is doubled, for example https://domain.tld/subdir/subdir/index.php instead of just https://domain.tld/subdir/index.php It works fine with SEF URLs enabled.

Testing Instructions

1. Install Joomla in a subdirectory and disable all SEF URL options
2. Go to a category view and look at the feed URL in the header.
3. Download the feed and look into the output.

Actual result BEFORE applying this Pull Request

The link in for example <atom:link rel="self" type="application/rss+xml" is wrong

Expected result AFTER applying this Pull Request

The link in for example <atom:link rel="self" type="application/rss+xml" is correct.

Link to documentations

Please select:

• [ ] Documentation link for docs.joomla.org:

• [X] No documentation changes for docs.joomla.org needed

• [ ] Pull Request link for manual.joomla.org:

• [X] No documentation changes for manual.joomla.org needed

[richard67]

@Hackwar Is there a reason why not fixing it for 4.4-dev?

[Hackwar]

Numerous of my PRs for 4.4 have been declared as new features even though they were bugfixes and rejected, so I stopped creating PRs for 4.4.

[richard67]

@Hackwar New features go into 5.1-dev. Bug fixes for bugs which affect 4.4 and 5.x go into 4.4-dev. Into 5.0-dev only bug fixes go where the bug doesn’t affect 4.4.

[Hackwar]

I'm very well aware of that, but my time is not free and if I create bugfixes like #42693 and get told that this PHP error is not something which will be fixed in 4.4, then I'll stop creating fixes for 4.4. I don't have to waste my time and the time of other contributors by creating a PR for 4.4, organising people to test that PR, them investing the time to actually test, and then be told that an obvious bug is not a bug and that the PR is going to be rejected. So I'm skipping that whole part and create PRs against the next branch up.

[Globulopolis]

I have tested this item :white_check_mark: successfully on fda45a77a9424fe399465d9596ccfe9b8f4525ea

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.}

[viocassel]

I have tested this item :white_check_mark: successfully on fda45a77a9424fe399465d9596ccfe9b8f4525ea

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.}

[richard67]

@Hackwar After our talk yesterday in the CMS Maintenance Team you said you will make this PR for 4.4-dev. Will you rebase this one, or will you make a new one? I'm asking because this one here has 2 good tests so it would be RTC (if not for the wrong branch).

[Hackwar]

I recreated the PR with 4.4-dev as base branch. The code is identical. Do we need new tests?

[richard67]

@Globulopolis @viocassel Could you test this PR again on 4.4.x? Thanks in advance.

[viocassel]

I have tested this item :white_check_mark: successfully on b3ef2726f8fe3ce94afee435c5dca30f495dd3b9

👌

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.}

[den1ska07]

I have not tested this item.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.}

[den1ska07]

I have not tested this item.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.}

[richard67]

I have not tested this item.

@den1ska07 If you submit a test result you have to select the right result before submitting.

[Globulopolis]

I have tested this item :white_check_mark: successfully on b3ef2726f8fe3ce94afee435c5dca30f495dd3b9

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.}

[den1ska07]

I have tested this item :white_check_mark: successfully on b3ef2726f8fe3ce94afee435c5dca30f495dd3b9

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42802.}

[laoneo]

Thanks!