joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.1] Convert mod_wrapper to service provider

Open joomlaweby opened this issue 1 year ago • 6 comments
trafficstars

Summary of Changes

Converts the wrapper module to service provider.

Testing Instructions

  1. Make sure you have site module mod_wrapper published and configured
  2. You should see module output on frontend

mod_wrapper

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [X] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [X] No documentation changes for manual.joomla.org needed

joomlaweby avatar Feb 11 '24 18:02 joomlaweby

https://github.com/joomla/joomla-cms/blob/c74906ea80039cb1c01093648b3dc310d2807cc4/modules/mod_wrapper/src/Helper/WrapperHelper.php#L35

public static function getParams(&$params) is deprecated will be removed in 6.0 Please change this function to a non-static function.

sandewt avatar Feb 12 '24 09:02 sandewt

public static function getParams(&$params) is deprecated will be removed in 6.0 Please change this function to a non-static function.

@sandewt resolved..thanks for review

joomlaweby avatar Feb 12 '24 19:02 joomlaweby

I have tested this item :white_check_mark: successfully on 62151be2f7df16162eb50790192243cdc35d2ccd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.

fgsw avatar Feb 13 '24 08:02 fgsw

I have tested this item :white_check_mark: successfully on 4706e0bceb53353d5b2d9a0ff0d6b68f2d661555


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.

ceford avatar Feb 21 '24 12:02 ceford

I have tested this item :white_check_mark: successfully on 4706e0bceb53353d5b2d9a0ff0d6b68f2d661555


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.

viocassel avatar Feb 21 '24 13:02 viocassel

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.

richard67 avatar Feb 22 '24 17:02 richard67

Thank you @joomlaweby and also testing and review @sandewt @fgsw @viocassel @ceford

LadySolveig avatar Feb 25 '24 22:02 LadySolveig