joomla-cms
joomla-cms copied to clipboard
[5.1] Convert mod_wrapper to service provider
Summary of Changes
Converts the wrapper module to service provider.
Testing Instructions
- Make sure you have site module mod_wrapper published and configured
- You should see module output on frontend
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
-
[ ] Documentation link for docs.joomla.org:
-
[X] No documentation changes for docs.joomla.org needed
-
[ ] Pull Request link for manual.joomla.org:
-
[X] No documentation changes for manual.joomla.org needed
https://github.com/joomla/joomla-cms/blob/c74906ea80039cb1c01093648b3dc310d2807cc4/modules/mod_wrapper/src/Helper/WrapperHelper.php#L35
public static function getParams(&$params) is deprecated will be removed in 6.0
Please change this function to a non-static function.
public static function getParams(&$params)is deprecated will be removed in 6.0 Please change this function to a non-static function.
@sandewt resolved..thanks for review
I have tested this item :white_check_mark: successfully on 62151be2f7df16162eb50790192243cdc35d2ccd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.
I have tested this item :white_check_mark: successfully on 4706e0bceb53353d5b2d9a0ff0d6b68f2d661555
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.
I have tested this item :white_check_mark: successfully on 4706e0bceb53353d5b2d9a0ff0d6b68f2d661555
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.
Thank you @joomlaweby and also testing and review @sandewt @fgsw @viocassel @ceford